Re: [PATCH net-next v2] mptcp: sockopt: implement IPV6_TCLASS
Geliang Tang <[email protected]> Mon, 27 Jul 2026 19:58:24 +0800
| Newsgroups | dev.linux.lists.mptcp,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hi David, Matt, On Tue, 2026-07-14 at 11:53 +0200, Matthieu Baerts wrote: > Hi David, Geliang, > > On 14/07/2026 11:48, David 'equinox' Lamparter wrote: > > On Tue, Jul 14, 2026 at 10:22:12AM +0800, Geliang Tang wrote: > > > Thanks for your patch. However there is already a version under > > > review > > > on the MPTCP mailing list that adds IPV6_TCLASS [1] (as well as > > > IP_TTL > > > and IPV6_UNICAST_HOPS). > > > > > > https://patchwork.kernel.org/project/mptcp/patch/2617b8684039574734b8622936ef126d6a7cd519.1754986785.git.tanggeliang@kylinos.cn/ > > > > Darn, I looked for patches for this & didn't find any, but I've > > also > > been carrying this locally for a bit. > > > > Anything I can do to help get your patch moving? > I was hoping to do some refactoring around Geliang's code, but I > didn't > manage to do that so far. I will to see if it is fine to apply > Geliang's > patch (after netdevconf) and do the refactoring after. > > @Geliang: do you mind rebasing this series, please? No hurry, I can > also > check later on. (And sorry for the delay on that) I finally had time to do this IPV6_TCLASS refactoring. I merged my changes into David's patch, keeping David as the patch author and adding "Co-developed-by" tag for myself. To verify the correctness of IPV6_TCLASS, I added IPV6_TCLASS support to "NVMe over MPTCP" feature I'm currently working on, and all the tests passed. I will include this IPV6_TCLASS patch in my upcoming v3 of "Fix socket options used by NVMe over MPTCP" soon. Thanks, -Geliang > > Cheers, > Matt