Re: [PATCH mptcp-next v11 1/4] mptcp: sockopt: factor inet_flags propagation into a mask

Paolo Abeni <[email protected]> Wed, 29 Jul 2026 09:46:13 +0200
Newsgroups dev.linux.lists.mptcp
Message-ID <[email protected]>
Hi,

I'm sorry for the prolonged lack of feedback: persistent ENOTIME here.
This iteration LGTM, with a few nitpicking that possibly could be
addressed at application time, see below and next patches.

On 5/31/26 4:59 PM, David Carlier wrote:
> @@ -1551,6 +1555,9 @@ static void sync_socket_options(struct mptcp_sock *msk, struct sock *ssk)
>  {
>  	static const unsigned int tx_rx_locks = SOCK_RCVBUF_LOCK | SOCK_SNDBUF_LOCK;
>  	struct sock *sk = (struct sock *)msk;
> +	unsigned long mask = MPTCP_INET_FLAGS_MASK;
> +	unsigned long src;
> +	int b;
>  	bool keep_open;

Ordering above.

/P