Re: [PATCH export v3 3/4] mptcp: reset subflow on MP_FAIL when OoO queue is non-empty
Paolo Abeni <[email protected]>
| Newsgroups | dev.linux.lists.mptcp |
|---|---|
| Message-ID | <[email protected]> |
On 8/12/26 7:46 AM, Chenguang Zhao wrote: > From: Chenguang Zhao <[email protected]> > > Infinite mapping needs contiguous data. If the MPTCP OoO queue is not > empty, reset the subflow instead of falling back. Why? the RFC says: """if all unacknowledged data in flight is contiguous""" That statement can be true even when the RTX queue is not empty. It will become false if/when some mptcp-level retransmission will happen. __mptcp_push_retrans() atomically sets `allow_infinite_fallback` to false when such retransmission happen. The code just before the newly added one checks such condition under the relevant lock. I don't think this change is needed. /P