[PATCH mptcp-net 0/2] selftests: mptcp: lib: get MIB counters for the right test
"Matthieu Baerts (NGI0)" <[email protected]>
| Newsgroups | dev.linux.lists.mptcp |
|---|---|
| Message-ID | <[email protected]> |
In case of errors, mptcp_lib_pr_nstat is called to dump the nstat counters, but for some tests, it was dumping the counters for all subtests, not just the current one. That's an issue for tests that don't recreate the netns for each subtest, e.g. mptcp_connect.sh. In this case, 'nstat -a' will look at the absolute counters since the creation of the netns, making debugging harder. Instead, it should dump the counters for the current test, by using the history recorded in /tmp/<ns>.nstat, if available, and not using '-a' which was dumping the absolute values instead of calculating increments. While at it, rename the previous 'hist' variable to 'cache' as it was used to look at the cache, not the nstat history. Do the same in mptcp_lib_get_counter, even if it wasn't an issue for the moment. Still, good to fix it for future usage, and to align it with the rest. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> --- Matthieu Baerts (NGI0) (2): selftests: mptcp: lib: dump nstat for the right test selftests: mptcp: lib: get counters for the right test tools/testing/selftests/net/mptcp/mptcp_lib.sh | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) --- base-commit: ab76ed72e0bed8352d3b8e2b4d1be7c823e5fba3 change-id: 20260813-sft-mptcp-nstat-hist-33411708430f Best regards, -- Matthieu Baerts (NGI0) <[email protected]>