Re: [PATCH mptcp-net] mptcp: pm: reset retrans_time when ADD_ADDR entry is reused
Matthieu Baerts <[email protected]>
| Newsgroups | dev.linux.lists.mptcp |
|---|---|
| Organization | NGI0 Core |
| Message-ID | <[email protected]> |
Hi Mat, On 14/08/2026 03:22, Mat Martineau wrote: > On Wed, 5 Aug 2026, Matthieu Baerts (NGI0) wrote: > >> When an ADD_ADDR entry is reused, the timer is re-armed, because the >> goal is to re-announce an ADD_ADDR, and eventually retransmit it if >> needed. >> >> In this case, the retransmission counter should be reset as well, so the >> re-announced address gets its retransmissions back instead of relying on >> what was left before, and possibly not being able to retransmit it. (...) > Looks good to me, thanks for the fix. Thank you for the review! Now in our tree: New patches for t/upstream-net and t/upstream: - f9ff581a97d0: mptcp: pm: reset retrans_time when ADD_ADDR entry is reused - Results: 745049d83503..79d7297194ac (export-net) - Results: d536472a82d1..199ed983c1f7 (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/9bf507e411f4bc32904bdf34fdbe9e9406e9d025/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/ba6afbce3cb1ec026c104c44bfebe101bbd2ef35/checks Cheers, Matt -- Sponsored by the NGI0 Core fund.