Re: [PATCH mptcp-next v2 2/5] mptcp: pm: change path_manager sysctl atomically
Matthieu Baerts <[email protected]>
| Newsgroups | dev.linux.lists.mptcp,dev.linux.lists.sashiko-reviews |
|---|---|
| Organization | NGI0 Core |
| Message-ID | <[email protected]> |
Hi Gang, On 18/08/2026 14:57, [email protected] wrote: > August 18, 2026 at 6:00 PM, [email protected] mailto:[email protected] wrote: > > >> >> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: >> - [High] Missing module reference counting when setting the path manager sysctl leads to a Use-After-Free. >> - [High] Missing module reference counting when setting the scheduler sysctl leads to a Use-After-Free. >> -- > > Hi, Matt > > As described in [1], it is safe for now. > > Do you have some suggestions here? Or we can ignore these. We can indeed ignore. Do you mind adding a comment in the commit message in your v3 to tell Sashiko that the module reference counting is done in patch X of this series? Just to see if it helps Sashiko to avoid such messages. Cheers, Matt -- Sponsored by the NGI0 Core fund.