Re: [PATCH v4 1/4] nvmet-tcp: unify sockopt with do_sock_setsockopt

On Wed, Aug 19, 2026 at 11:04:39AM +0200, Christoph Hellwig wrote:
> On Tue, Aug 18, 2026 at 02:03:00PM +0800, Geliang Tang wrote:
> > From: Geliang Tang <[email protected]>
> > 
> > This patch consolidates socket option settings in nvmet-tcp by utilizing
> > the generic do_sock_setsockopt() helper for options including SO_LINGER,
> > SO_PRIORITY, SO_REUSEADDR, TCP_NODELAY, and IP_TOS. This change eliminates
> > the need to export and use specialized helpers for each individual socket
> > option.
> 
> Hmm.  I see that do_sock_setsockopt is exported, but it really should
> not be.  It's really just an internal helper exposed for io_uring
> and no modular code should be using it (never mind the non-GPL export).

Agreed. I am happy to remove the export, given it was introduced by my
change in commit 1406245c2945 ("net/socket: Break down
__sys_setsockopt")