Re: [PATCH v4 13/13] gpu: nova-core: store Fsp instance in Gpu

"Eliot Courtney" <[email protected]>
Newsgroups dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux
Message-ID <[email protected]>
On Mon Jun 29, 2026 at 11:09 PM JST, Alexandre Courbot wrote:
> The `Fsp` instance was only used in the Hopper+ boot path, and
> consequently built locally (and immediately dropped) in it.
>
> This worked well as a temporary measure, but the FSP is a GPU
> sub-device, so its lifetime should match the GPU rather than a single
> boot invocation.
>
> It will also be needed in other parts of the driver, for instance vGPU.
>
> Thus, create the `Fsp` instance in the `Gpu` constructor and store it
> there, passing it to the GSP boot as a mutable reference using
> `GspBootContext`. This makes the `Fsp` available even after the GSP is
> booted.
>
> Signed-off-by: Alexandre Courbot <[email protected]>
> ---

Reviewed-by: Eliot Courtney <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.