Re: [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files
Timur Tabi <[email protected]>
| Newsgroups | dev.linux.lists.nova-gpu,dev.linux.lists.driver-core,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2026-07-02 at 14:27 -0500, Timur Tabi wrote:
> + pub(crate) fn get_bytes(&self, tag: &[u8; 4]) -> Result<&'a [u8]> {
> + let tlv = self.find(tag)?;
> +
> + Ok(tlv.value)
> + }
I forgot to update get_bytes() to return an error if the value is empty. That should address a lot
of potential issues, including the ones that Sashiko raised.