Re: [PATCH 3/4] drm: nova: Add GETPARAM parameter to read the GPU chipset
"Danilo Krummrich" <[email protected]>
| Newsgroups | dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Mon Jul 6, 2026 at 7:35 PM CEST, Timur Tabi wrote:
> On Mon, 2026-07-06 at 15:34 +1000, Alistair Popple wrote:
>> @@ -38,6 +38,7 @@ pub(crate) fn get_param(
>>
>> let value = match getparam.param as u32 {
>> uapi::NOVA_GETPARAM_VRAM_BAR_SIZE => pdev.resource_len(1)?,
>> + uapi::NOVA_GETPARAM_GPU_CHIPSET => reg_data.api.chipset() as u64,
>
> Can we assign these IOCtl values to match Nouveau as much as possible? I think it would make
> everyone's life easier if we could use the same user-space tools/libraries for Nova that we do for
> Nouveau.
I don't mind using the same numbers where it doesn't matter too much, but for
this to work, it would also require us to retain layout compatibility with
structures, semantics, etc., which I think we should not bother with at all.
Let's build a clean new uAPI, it will get messy over time by itself. :)