Re: [PATCH v4 1/7] rust: firmware: add request_into_buf()
"Danilo Krummrich" <[email protected]> Fri, 10 Jul 2026 01:02:46 +0200
| Newsgroups | dev.linux.lists.nova-gpu,dev.linux.lists.driver-core,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Fri Jul 10, 2026 at 12:46 AM CEST, Timur Tabi wrote:
> On Thu, 2026-07-09 at 16:39 -0500, Timur Tabi wrote:
>> - error::Error,
>> - error::Result,
>> + error::*,
>
> ...
>
>> + if buf.is_empty() {
>> + return Err(crate::error::code::EINVAL);
>> + }
>
> Sorry, I just noticed that this is wrong. I'll fix it in v5.
Please also drop the imports above and use prelude instead.