Re: [PATCH 0/3] gpu: nova-core: Move PFB and PBUS register
Nanonej Dev <[email protected]> Tue, 21 Jul 2026 15:46:59 +0000
| Newsgroups | dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <OprRCKDmuvyHtJbjO71JS5CO4up4JGOsy85dYGzOQu6mwC8N-9dihiX_h-NmEcCoxb2bUVDb_kGcpA-H58Y6ZOrumPp_Dj5X3iUa4AjZLts=@nanonej.com> |
> There could be a function in the `fb` module that reads the registers > and returns an `Option<Range<u64>>` - `None` if `is_wpr2_set` is > `false`, or the WPR2 range otherwise. Then the GSP TU102 HAL would just > use this function instead of poking the register as it currently does. > > Doing so would move the WPR2 registers to the right place, and provide the > right abstraction for the WPR2 region. > > A patch series doing this could look like this: > > - Add the `fb` module function abstracting the WPR2 region registers and > use it in the GSP's TU102 HAL. > - Move the `NV_PFB_PRI_MMU_WPR2_ADDR*` registers under the `fb` module. > - Move the `NV_PBUS_SW_SCRATCH_0E_FRTS_ERR` register under the `gsp` > module, since it is clearly themed after `FRTS`, which is part of the > GSP boot. But, without moving `NV_PBUS_SW_SCRATCH` (the actual > register being aliased). I expect you will hit a bug of the `register` > macro when doing this one - I'll try to address it, but the first two > steps should be safe to do and correct. Thanks for the plan Alexandre, worked like a charm.
signature.asc
(application/pgp-signature, 343 B)
-----BEGIN PGP SIGNATURE----- Version: ProtonMail wrsEARYKAG0FgmpflFsJEFKmzSsu6sDwRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmeAsFbFD8EepBCx9XY+x0Eu6GhsEMYdWe02x+Kx lamwiRYhBI+99gDJjAW7MoHJ0VKmzSsu6sDwAADy4AD+KhUkNxpNcXkcZ2p+ wA47FeTA/Z1+LqsetiGdBFiHtEwA/2DzSUFqPoZKYx1BWMbg1cMUcTuxIobW 45ZN2/TlVasH =PPKZ -----END PGP SIGNATURE-----