[PATCH v5 0/6] gpu: nova-core: boot GSP with vGPU enabled
Zhi Wang <[email protected]> Wed, 22 Jul 2026 10:39:07 +0300
| Newsgroups | dev.linux.lists.nova-gpu,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Booting GSP with vGPU enabled is part of the first milestone (M1) together with the Rust fwctl abstraction [1] and the nova-core fwctl driver [2] for upstream vGPU support. It allows us to validate the basic GSP boot flow with vGPU enabled and upload vGPU types even before the remaining nova-core dependencies are ready. The nova-vGPU WIP patches for all milestones can be found at [3]. This version is based on the latest drm-rust-next, which now includes Alexandre's v6 GSP boot process consolidation series [4]. Changes in v5: - Rebase on the latest drm-rust-next. - Move sriov_get_totalvfs() to the Device<Core> implementation and keep vGPU state detection on the Core typestate. (Danilo) - Preserve the VF count as NonZero<u16> in VgpuState and unwrap it only at the firmware u8 conversion boundary. (Alex) - Rename patch 4 to "gpu: nova-core: detect and store vGPU state". (Alex) - Pass pdev directly to the device logging macros, retaining .as_ref() only for the FSP method that takes Device<Bound>. (Alex) Link to v4 [5] Changes in v4: - Rebase on the latest drm-rust-next and Alexandre's v6 GSP boot process consolidation series. - Add a conditional C helper for pci_sriov_get_totalvfs() so the Rust abstraction also builds when CONFIG_PCI_IOV is disabled. - Return Option<NonZero<u16>> from the Rust SR-IOV helper so callers must handle the unavailable-SR-IOV case explicitly. - Derive Debug for VgpuState and log the complete state when VgpuManager is constructed. - Warn and fall back to VgpuState::Disabled when the optional vGPU state cannot be detected, so a detection failure does not prevent a bare-metal probe. - Document vGPU state detection, split the vGPU HAL implementations into per-chip modules, and call the HAL method directly through the exposed trait and selector. v3: - Split the FSP response header rename from the FSP PRC vGPU mode query into a separate patch. - Change pci_sriov_get_totalvfs() to return unsigned int on the C side while keeping the Rust helper as u16. - Move the vGPU capability gate into a dedicated vgpu::hal module. - Represent detected vGPU state as VgpuState instead of separate enabled/total_vfs accessors. - Keep total_vfs values below 2 on the disabled path, with an explicit comment for the current single-VF limitation. - Use the generated 570.144 GSP_FW_HEAP_SIZE_VGPU_DEFAULT binding for vGPU WPR2 heap sizing, and keep unsupported 0/1-VF states out of the vGPU heap path through VgpuState. v2: - Rebase on top of Alexandre's GSP boot process consolidation series. - Drop the FSP response, FSP documentation, and GspBootContext patches that are already in drm-rust-next or superseded by the prerequisite boot consolidation series. - Change pci_sriov_get_totalvfs() to return u16 and update existing C callers accordingly. - Make the Rust sriov_get_totalvfs() helper return u16 directly. - Rework the FSP PRC vGPU mode query to use typed subcommand, object ID, flags, request, and response structures. - Move vGPU state detection before GSP boot into a read-only VgpuManager, avoiding Mutex/Cell based mutation during boot. - Add a HAL method for the vGPU capability gate. - Split the SetRegistry changes into a dynamic-entry refactor and the RMSetSriovMode functional change. - Rework WPR2 heap sizing to consume VgpuManager, keep the vGPU heap-size helper in gsp/fw.rs, and drop the 1VM heap-size special case. [1] https://lore.kernel.org/rust-for-linux/[email protected]/ [2] https://lore.kernel.org/rust-for-linux/[email protected]/ [3] https://github.com/zhiwang-nvidia/nova-core/tree/zhi/nova-vgpu-wip [4] https://lore.kernel.org/all/[email protected]/ [5] https://lore.kernel.org/nova-gpu/[email protected]/ Zhi Wang (6): PCI/IOV: Return unsigned int from pci_sriov_get_totalvfs() rust: pci: add sriov_get_totalvfs() helper gpu: nova-core: read vGPU mode from FSP via PRC protocol gpu: nova-core: detect and store vGPU state gpu: nova-core: set RMSetSriovMode for vGPU gpu: nova-core: reserve vGPU WPR2 heap drivers/gpu/nova-core/fb.rs | 25 ++- drivers/gpu/nova-core/fsp.rs | 172 ++++++++++++++++++ drivers/gpu/nova-core/gpu.rs | 7 + drivers/gpu/nova-core/gsp.rs | 2 + drivers/gpu/nova-core/gsp/boot.rs | 4 +- drivers/gpu/nova-core/gsp/commands.rs | 14 +- drivers/gpu/nova-core/gsp/fw.rs | 5 + .../gpu/nova-core/gsp/fw/r570_144/bindings.rs | 1 + drivers/gpu/nova-core/mctp.rs | 2 + drivers/gpu/nova-core/nova_core.rs | 1 + drivers/gpu/nova-core/vgpu.rs | 91 +++++++++ drivers/gpu/nova-core/vgpu/hal.rs | 25 +++ drivers/gpu/nova-core/vgpu/hal/gb202.rs | 15 ++ drivers/gpu/nova-core/vgpu/hal/tu102.rs | 15 ++ drivers/pci/iov.c | 2 +- include/linux/pci.h | 4 +- rust/helpers/pci.c | 8 + rust/kernel/pci.rs | 13 ++ 18 files changed, 395 insertions(+), 11 deletions(-) create mode 100644 drivers/gpu/nova-core/vgpu.rs create mode 100644 drivers/gpu/nova-core/vgpu/hal.rs create mode 100644 drivers/gpu/nova-core/vgpu/hal/gb202.rs create mode 100644 drivers/gpu/nova-core/vgpu/hal/tu102.rs base-commit: 22e77d81d0a9ab3aee1c5538b3f2f8a66930bfa7 -- 2.53.0