Re: [PATCH 2/3] gpu: nova-core: Move PFB registers definitions
Nanonej Dev <[email protected]> Mon, 27 Jul 2026 15:17:53 +0000
| Newsgroups | dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <cN4Q2hbbRw9FAjcXaAsublR_qeeRSpeV4MYDxyR4lZet4wMCdudh-4NZ1omxTpA-q8ZkDmpwmpBRnpwbm3Fa-Z1kxH-Z2ga4L3iZU3FMt5I=@nanonej.com> |
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------062b81900832d9fd48c31af0f76290d25e570df9d84b46b45996312013de7305 Content-Type: multipart/mixed;boundary=---------------------78f145c0554e067b9125a7fea6ccbc39 -----------------------78f145c0554e067b9125a7fea6ccbc39 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 > Every patch needs a commit message, even if short. Ok, you mean a body then I guess? Cause my commit have a message but b4 turned it in the patch subject, so I= guess I must also add a body. > (also please check whether the issue raised by Sashiko [1] has merit) > > [1] https://sashiko.dev/#/patchset/20260721-nova-core-regs-split-v1-0-38= [email protected]?part=3D2 It make sense, but I didn't find how to check the generated doc in docs ke= rnel rust [1]. So for my fix I just reverted to the absolute `crate::fb::SysmemFlush`, bu= t if it is really tied to rustdoc I would be glad to know how to generate = it and check it correctly. [1] https://docs.kernel.org/rust > One more comment inline, but this is pretty much what I had in mind; so > looking pretty good imho! Ok, happy to read that, thanks! -----------------------78f145c0554e067b9125a7fea6ccbc39-- --------062b81900832d9fd48c31af0f76290d25e570df9d84b46b45996312013de7305 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wrsEARYKAG0FgmpndooJEFKmzSsu6sDwRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmfMcgiZCeO+WFZOOPtgJE0EeVkZIxfONYkoYotV bRmwEhYhBI+99gDJjAW7MoHJ0VKmzSsu6sDwAAAtDAD6ApGHfXvnPCd+17Xu Hy2gSlxiu2Lpvpa/GFNpIqJVlcEA/RFS+K2l8LG6/DY3Xm5YMrfC04Z4zjlS BJVWfH1Sb9kP =c9XG -----END PGP SIGNATURE----- --------062b81900832d9fd48c31af0f76290d25e570df9d84b46b45996312013de7305--