Re: [PATCH 08/10] gpu: nova-core: use projection for PFALCON and PFALCON2 registers
"Danilo Krummrich" <[email protected]> Tue, 28 Jul 2026 20:56:27 +0200
| Newsgroups | dev.linux.lists.nova-gpu,dev.linux.lists.driver-core,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Tue Jul 28, 2026 at 8:26 PM CEST, Gary Guo wrote: > On Tue Jul 28, 2026 at 6:01 PM BST, Danilo Krummrich wrote: >> I may have a slight preference for a separate subregion() variant for th= e >> purpose of working around generic_const_exprs, as it probably is a bit c= loser to >> the final solution, but trait methods are fine with me too. > > I am not sure that's the final solution that I want. I want arg-position > const-generics which would syntactically look more similar to `build_asse= rt!`. arg-position const generics would be great, but that's just a syntax differ= ence and not related to supporting expressions involving const generics? In any case, I think my point about being closer to the final solution hold= s regardless. > Personally I think most issues with `build_assert!` can be fixed by havin= g > lints, which is on my radar. I think it can be improved, but in the end it relies on compiler optimizati= on that may or may not happen as expected.