Re: [PATCH 08/10] gpu: nova-core: use projection for PFALCON and PFALCON2 registers

On Wed Jul 29, 2026 at 8:28 PM BST, Danilo Krummrich wrote:
>> The offset for `subregion` is no different to the offset for `read()`. I=
n both
>> cases you are supposed to only supply build-time const values; and in bo=
th cases
>> you can argue they are needed there due to const generics being too limi=
ted to
>> what they do.
>
> I see where you are coming from, but I see it from a different angle:
>
> An offset given to read() can legitimately be a runtime value that happen=
s to be
> constrained in a way that the compiler can proof that it is within bounds=
 (with
> dead code elimination doing the rest). We have reasonable use-cases where=
 the
> offset given to read() is not a "true" constant, and hence build_assert! =
is the
> correct tool.
>
> subregion() is different in this regard, as we do not have reasonable use=
-cases
> where the offset is not a "true" constant. (And I would guess that this a=
lso
> made you choose the implementation you picked for this patch.)

I think it's the same. Imagine instead of register arrays, you have subregi=
on
arrays.

>
> It just happens that we hit a language limitation where const evaluation =
of a
> "true" constant does not work, but that does not make build time assertio=
n the
> correct tool, it just makes it a workaround for the existing limitation.
>
> This is also in line with the documentation in rust/kernel/build_assert.r=
s.
>
>> We probably could even just add a method that gives you a subregion base=
d on
>> `IoLoc` similar to other methods. This actually might be a good idea tha=
t I'd
>> pursue in next version.
>
> So, you are proposing that subregion() takes an argument of type
> L: impl IoLoc<_>?
>
> Where would this argument come from?
>
> I assume you would need to bring back
>
> 	impl RegisterBase<Foo> for Bar {
> 	    const BASE: usize =3D 0xff;
> 	}
>
> impl blocks? Which seems like just adding boilerplate? Or do you have som=
ething
> else in mind?

No, I was thinking of

    struct MySubRegion([u8; 4096]);

    impl Register for MySubRegion {
        type Storage =3D Self;
        const OFFSET: usize =3D ...;
    }

this can be generated with `register!` macro if you can attach a specific t=
ype
and not have it generate `bitfield!()`.

E.g.

    struct MySubRegion([u8; 4096]);

    register! {
        pub SUBREGION: MySubRegion @ 0x1000;
    }


Best,
Gary