Re: [PATCH 0/2] rust: kunit: enforce test configurability
Miguel Ojeda <[email protected]>
| Newsgroups | dev.linux.lists.nova-gpu,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <CANiq72m2M5Csh_9qQYa8MRmJZtciU3d4S3ht5FG-K+YwR4iAwQ@mail.gmail.com> |
On Tue, Aug 18, 2026 at 5:23 PM Yury Norov <[email protected]> wrote: > > Make every Rust KUnit test suite require the Kconfig option that controls > it, and let the `kunit_tests` macro apply the corresponding `#[cfg]` > attribute. If we are sure we always want at least one `cfg` guarding them, then yeah, this makes sense (we could ask to write the `cfg` bit inside, for "greppability", and for clarity / less ambiguity later on). David: are there cases on KUnit where you would recommend/prefer something different? For instance, I could imagine a Rust `mod` for testing purposes already gated by a `cfg` that is meant to contain many tests, and then different suites inside that for control (possibly with extra `cfg`s, but maybe none too for some). Cheers, Miguel