Re: [PATCH 09/27] gpu: nova-core: add build ID headers to debugfs log buffer dumps

On 8/19/26 11:20 AM, Timur Tabi wrote:
> On Tue, 2026-08-18 at 20:52 -0700, John Hubbard wrote:
> 
> 
>> diff --git a/drivers/gpu/nova-core/firmware.rs b/drivers/gpu/nova-core/firmware.rs
>> index dfd41364cc77..e0befe84aa3e 100644
>> --- a/drivers/gpu/nova-core/firmware.rs
>> +++ b/drivers/gpu/nova-core/firmware.rs
>> @@ -31,6 +31,40 @@
>>  pub(crate) mod riscv;
>>  pub(crate) mod tlv;
>>  
>> +/// Maximum length of a build ID, matching Open RM's `BUILD_ID_MAX_LENGTH`.
>> +const BUILD_ID_MAX_LENGTH: usize = 32;
> 
> Um, I recently made a change to the script that expands the build ID from a 32-byte hex 
> 
> [3] tag="BLID" length=20
>   00000000  b5 9b b5 6c 76 7e 1e 34 ef 86 45 c6 73 31 f6 a6  |...lv~.4..E.s1..|
>   00000010  5b 8a 5c 3e                                      |[.\>|
> 
> to a 64-byte string:
> 
> [7] tag="BLID" length=40
>   00000000  39 65 37 64 39 35 66 35 32 62 63 30 36 66 37 63  |9e7d95f52bc06f7c|
>   00000010  66 31 61 34 36 37 37 35 61 64 34 35 30 63 63 63  |f1a46775ad450ccc|
>   00000020  65 66 66 34 35 35 65 34                          |eff455e4|
> 
> I'm assuming you want me to change that back?  I didn't realize the build ID was actually going
> to be used by the driver.

Well, let's do whatever is best. If you really want/need BLID to be 64 bytes
then I can update this series to match.

thanks,
-- 
John Hubbard