Re: [PATCH] gpu: nova-core: fix incorrect naming/framing of GSP-FMC firmware
"Eliot Courtney" <[email protected]>
| Newsgroups | dev.linux.lists.nova-gpu,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Tue Aug 25, 2026 at 5:31 PM JST, Alexandre Courbot wrote: > The GSP-FMC firmware code lived in `firmware/fsp.rs` and described > itself as running on the FSP. This is incorrect: GSP-FMC is loaded by > the FSP, but runs on the GSP as the loader and verifier of GSP-RM. FSP > secure-boots on its own before the driver even starts. > > Correct the naming and files used to contain the GSP-FMC code, by: > > - Renaming `firmware/fsp.rs` to `firmware/gsp_fmc.rs` (as GSP-FMC is not > the FSP firmware), > - Changing the prefix of some declarations in that file to `FMC` or > `GspFmc` (interestingly some were already correct), > - Fixing a mismatch (FMC means "First Mutable Code") in `fsp.rst`. > > Signed-off-by: Alexandre Courbot <[email protected]> > --- Reviewed-by: Eliot Courtney <[email protected]>