Re: [PATCH 06/15] PCI: endpoint: pci-epf-vntb: Fold MW runtime state into a struct

Koichiro Den <[email protected]> Tue, 17 Mar 2026 12:13:24 +0900
Newsgroups dev.linux.lists.ntb,org.kernel.vger.dmaengine,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci
Message-ID <735od76ic3rkz6imi2fguvjhi3nd5spjxpdesgt75nqnor6h4a@jahba3ai3iba>
On Thu, Mar 12, 2026 at 04:35:11PM -0400, Frank Li wrote:
> On Fri, Mar 13, 2026 at 01:49:56AM +0900, Koichiro Den wrote:
> > The next patches add per-memory-window offsets, shared BAR placement,
> > and optional DMA export state. Keeping per-window state in parallel
> > arrays would make that work noisy and error-prone.
> >
> > Group the runtime memory-window state into struct epf_ntb_mw so
> > follow-up changes can extend a single object instead of touching
> > multiple arrays.
> 
> Simple said
> 
> PCI: endpoint: pci-epf-vntb: collect MW information into a struct
> 
> Group the runtime memory window state into struct epf_ntb_mw to improve
> readability and make the code easier to extend.
> 
> No functional change intended.

Right, I'll update it when respinning.

Thanks for the review,
Koichiro

> 
> Reviewed-by: Frank Li <[email protected]>
> 
> >