Re: [PATCH] ntb: idt: Remove redundant dev_err()

On 7/15/26 8:25 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>

> ---
>  drivers/ntb/hw/idt/ntb_hw_idt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index f27df8d7f3b9..6793f7d4fc62 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2141,10 +2141,8 @@ static int idt_init_isr(struct idt_ntb_dev *ndev)
>  	/* Set the IRQ handler */
>  	ret = devm_request_threaded_irq(&pdev->dev, ret, NULL, idt_thread_isr,
>  					IRQF_ONESHOT, NTB_IRQNAME, ndev);
> -	if (ret != 0) {
> -		dev_err(&pdev->dev, "Failed to set MSI IRQ handler, %d", ret);
> +	if (ret != 0)
>  		goto err_free_vectors;
> -	}
>  
>  	/* Unmask Message/Doorbell/SE interrupts */
>  	ntint_mask = idt_nt_read(ndev, IDT_NT_NTINTMSK) & ~IDT_NTINTMSK_ALL;