Re: [PATCH 2/3] PCI: endpoint: pci-ep-msi: Make embedded doorbell IRQ exclusive
[email protected] Tue, 28 Jul 2026 17:28:52 +0000
| Newsgroups | dev.linux.lists.ntb,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Embedded doorbells may use the same virq for several messages. This does > not mean the IRQ itself should be shared. Consumers only need to request > each distinct virq once, as vNTB and pci-epf-test already do. >=20 > IRQF_SHARED would let different EPFs register handlers for the same IRQ. > The embedded doorbell interface cannot tell which EPF a write targets, > so every handler would handle it. >=20 > Only the first EPF can allocate doorbells today, so this cannot happen > yet. Drop IRQF_SHARED before extending the embedded backend to non-first > EPFs. A second request for the same IRQ will then fail with -EBUSY > instead of attaching another handler. >=20 > Signed-off-by: Koichiro Den <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260728172306.2751= [email protected]?part=3D2