[PATCH net 0/2] net: ntb_netdev: Fix RX statistics accounting
Koichiro Den <[email protected]>
| Newsgroups | dev.linux.lists.ntb,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hi, This series addresses Jakub's comment on ntb_netdev RX statistics accounting: https://lore.kernel.org/r/[email protected]/ It fixes the double counting and also the related packet/byte accounting on RX refill failure. Notes: - No ordering dependency on the TX completion/error handling series, which is currently awaiting review. Either series can go first. https://patchwork.kernel.org/project/netdevbpf/cover/[email protected]/ - Once both series land, I plan to post one follow-up patch to net for the multi-queue stats race introduced by commit 24d9e73c7e00 ("net: ntb_netdev: Support ethtool channels for multi-queue"). My plan is to move packet/byte/drop counters to core-managed per-CPU stats and use DEV_STATS_INC() for the remaining slow-path counters. IMO this is lower severity and better done after the TX/RX changes settle. Best regards, Koichiro Koichiro Den (2): net: ntb_netdev: Avoid double-accounting netif_rx() drops net: ntb_netdev: Count packets dropped on RX refill failure drivers/net/ntb_netdev.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) base-commit: 564973a259ec76f2dad0853420e7034cc43994c4 -- 2.51.0