Re: [PATCH 5/6] mm: reintroduce vma_desc_test() as a singular flag test
Pedro Falcato <[email protected]>
| Newsgroups | dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,org.kernel.vger.linux-cxl,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kvack.linux-mm,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <kci3actvfoj2rc2i6znf2ff24yu5q7ewgo2byqegmhjiv7ptzy@4ppp3xt5mwq2> |
On Thu, Mar 05, 2026 at 10:50:18AM +0000, Lorenzo Stoakes (Oracle) wrote: > Similar to vma_flags_test(), we have previously renamed vma_desc_test() to > vma_desc_test_any(). Now that is in place, we can reintroduce > vma_desc_test() to explicitly check for a single VMA flag. > > As with vma_flags_test(), this is useful as often flag tests are against a > single flag, and vma_desc_test_any(flags, VMA_READ_BIT) reads oddly and > potentially causes confusion. > > As with vma_flags_test() a combination of sparse and vma_flags_t being a > struct means that users cannot misuse this function without it getting > flagged. > > Also update the VMA tests to reflect this change. > > Signed-off-by: Lorenzo Stoakes (Oracle) <[email protected]> Reviewed-by: Pedro Falcato <[email protected]> Similarly LGTM. -- Pedro