Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently
Gregory Price <[email protected]>
| Newsgroups | dev.linux.lists.nvdimm,dev.linux.lists.damon,dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sgx,org.kernel.vger.linux-tegra,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <ak_EivwcDDdn1Xvp@gourry-fedora-PF4VCD3F> |
On Mon, Jun 29, 2026 at 01:23:30PM +0100, Lorenzo Stoakes wrote: > There are a number of places where we open code what linear_page_index() > and linear_page_delta() calculate. > > Replace this code with the appropriate functions for consistency. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes <[email protected]> one nit Reviewed-by: Gregory Price <[email protected]> ... > diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c > index c09bbe04be6c..536c25d8dcee 100644 > --- a/drivers/comedi/comedi_fops.c > +++ b/drivers/comedi/comedi_fops.c > @@ -25,6 +25,7 @@ > #include <linux/fs.h> > #include <linux/comedi/comedidev.h> > #include <linux/cdev.h> > +#include <linux/pagemap.h> > > #include <linux/io.h> > #include <linux/uaccess.h> > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > { > struct comedi_buf_map *bm = vma->vm_private_data; > unsigned long offset = > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > Obviously correct, but was this intended for a different patch? ~Gregory