Re: [PATCH v6 09/10] dax/kmem: add sysfs interface for atomic whole-device hotplug
"Dan Williams (nvidia)" <[email protected]>
| Newsgroups | dev.linux.lists.nvdimm,dev.linux.lists.driver-core,org.kernel.vger.linux-cxl,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
Gregory Price wrote:
> > So the "unknown" case does not need to be here.
> >
>
> mhp_online_type_to_str can technically return NULL, seems better to not
> just let a NULL dereference sit latent even if we can visually tell it
> can't happen today?
Oh, makes sense I was thinking "unknown" was only a result of the
drvdata missing case.
> > > + if (dax_kmem_state_is_online(data->state)) {
> > > + dev_warn(dev, "Hotplug regions stuck online until reboot\n");
> >
> > I like that the BUG() is avoided, but I think these should stay
> > dev_err() given the severity.
> >
>
> I had to go back to calling remove_memory() by default given different
> feedback, but I think if anything I will just modify the BUG() to a
> WARN() and call it a day.
ack.