Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently
Lorenzo Stoakes <[email protected]>
| Newsgroups | dev.linux.lists.nvdimm,dev.linux.lists.damon,dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sgx,org.kernel.vger.linux-tegra,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <alEJP-qEgSIUOp38@lucifer> |
On Thu, Jul 09, 2026 at 11:57:09AM -0400, Gregory Price wrote:
> On Thu, Jul 09, 2026 at 11:55:54AM -0400, Gregory Price wrote:
> > > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr,
> > > {
> > > struct comedi_buf_map *bm = vma->vm_private_data;
> > > unsigned long offset =
> > > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT);
> > > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT);
> > >
> >
> > Obviously correct, but was this intended for a different patch?
> >
> > ~Gregory
>
> bleh already caught, sorry for the noise :]
Haha no thanks for picking it up, many eyes bugs etc. etc. ;)
Cheers, Lorenzo