Re: [PATCH v2 26/33] mm/vma: update vma_shrink() to not pass start, pgoff parameters
Gregory Price <[email protected]>
| Newsgroups | dev.linux.lists.nvdimm,dev.linux.lists.damon,dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sgx,org.kernel.vger.linux-tegra,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <alFiODVaGwd_wYl4@gourry-fedora-PF4VCD3F> |
On Fri, Jul 10, 2026 at 09:17:07PM +0100, Lorenzo Stoakes wrote: > vma_shrink() is only used by relocate_vma_down() to shrink the tail of a > VMA. Therefore neither the start nor the pgoff parameters make any sense. > > It seemed we were passing the pgoff parameter solely to satisfy > vma_set_range()'s requirement for pgoff being specified. > > Since vma_set_range() is now isolated to vma.c, we can simply introduce > __vma_set_range() which sets only vma->vm_[start, end], and invoke this > instead, removing start and pgoff from vma_shrink() altogether. > > No functional change intended. > > Reviewed-by: Pedro Falcato <[email protected]> > Signed-off-by: Lorenzo Stoakes <[email protected]> Carry over from v1 Reviewed-by: Gregory Price <[email protected]>