[ndctl PATCH] ndctl.spec.in: make xmlto BuildRequires depend on rhel < 9

Alison Schofield <[email protected]> Wed, 22 Jul 2026 13:28:58 -0700
Newsgroups dev.linux.lists.nvdimm
Message-ID <[email protected]>
From: Michal Schorm <[email protected]>

'xmlto' is only needed alongside 'asciidoc' on RHEL < 9. On Fedora
and RHEL >= 9, documentation is built with 'rubygem-asciidoctor'
via '-Dasciidoctor=enabled', which does not require 'xmlto'. Move
the dependency inside the existing RHEL < 9 conditional.

Related: rhbz#2503124

Reposted from:
https://src.fedoraproject.org/rpms/ndctl/pull-request/4#

Assisted-by: Claude AI <[email protected]>
Signed-off-by: Michal Schorm <[email protected]>
Reviewed-by: Alison Schofield <[email protected]>
---

Michal, ndctl tool operates via mailing list, not PRs, so reposted
your fixup here.


 ndctl.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ndctl.spec.in b/ndctl.spec.in
index ae9466c45192..f6c0f6992249 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -12,6 +12,7 @@ Requires:	CXL_LNAME%{?_isa} = %{version}-%{release}
 BuildRequires:	autoconf
 %if 0%{?rhel} && 0%{?rhel} < 9
 BuildRequires:	asciidoc
+BuildRequires:	xmlto
 %define asciidoctor -Dasciidoctor=disabled
 %define libtracefs -Dlibtracefs=disabled
 %else
@@ -21,7 +22,6 @@ BuildRequires:	libtracefs-devel
 %define asciidoctor -Dasciidoctor=enabled
 %define libtracefs -Dlibtracefs=enabled
 %endif
-BuildRequires:	xmlto
 BuildRequires:	automake
 BuildRequires:	libtool
 BuildRequires:	pkgconfig
-- 
2.37.3