Re: [PATCH 4/4] ocfs2: remove redundant l_next_free_rec check in __ocfs2_find_path()

On Fri, Apr 03, 2026 at 05:08:03PM +0800, Joseph Qi wrote:
> The l_next_free_rec > l_count check after ocfs2_read_extent_block() in
> __ocfs2_find_path() is now redundant, as ocfs2_validate_extent_block()
> already performs this validation at block read time.
> 
> Remove the duplicate check to avoid maintaining the same validation in
> two places.
> 
> Signed-off-by: Joseph Qi <[email protected]>

LGTM
Reviewed-by: Heming Zhao <[email protected]>
> ---
>  fs/ocfs2/alloc.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 8639806bcbb8..08e137928080 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -1878,18 +1878,6 @@ static int __ocfs2_find_path(struct ocfs2_caching_info *ci,
>  		eb = (struct ocfs2_extent_block *) bh->b_data;
>  		el = &eb->h_list;
>  
> -		if (le16_to_cpu(el->l_next_free_rec) >
> -		    le16_to_cpu(el->l_count)) {
> -			ocfs2_error(ocfs2_metadata_cache_get_super(ci),
> -				    "Owner %llu has bad count in extent list at block %llu (next free=%u, count=%u)\n",
> -				    (unsigned long long)ocfs2_metadata_cache_owner(ci),
> -				    (unsigned long long)bh->b_blocknr,
> -				    le16_to_cpu(el->l_next_free_rec),
> -				    le16_to_cpu(el->l_count));
> -			ret = -EROFS;
> -			goto out;
> -		}
> -
>  		if (func)
>  			func(data, bh);
>  	}
> -- 
> 2.39.3
>