Re: [PATCH 20/34] ocfs2: Convert ocfs2_read_blocks to bh_submit()

On 5/26/26 1:19 AM, Matthew Wilcox (Oracle) wrote:
> Avoid an extra indirect function call by using bh_submit() instead of
> submit_bh().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> Cc: [email protected]

Looks fine.
Reviewed-by: Joseph Qi <[email protected]>
> ---
>  fs/ocfs2/buffer_head_io.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ocfs2/buffer_head_io.c b/fs/ocfs2/buffer_head_io.c
> index 44a4fa3dfbc0..4d3f03f99a8a 100644
> --- a/fs/ocfs2/buffer_head_io.c
> +++ b/fs/ocfs2/buffer_head_io.c
> @@ -321,11 +321,10 @@ int ocfs2_read_blocks(struct ocfs2_caching_info *ci, u64 block, int nr,
>  				continue;
>  			}
>  
> -			get_bh(bh); /* for end_buffer_read_sync() */
> +			get_bh(bh); /* for bh_end_read() */
>  			if (validate)
>  				set_buffer_needs_validate(bh);
> -			bh->b_end_io = end_buffer_read_sync;
> -			submit_bh(REQ_OP_READ, bh);
> +			bh_submit(bh, REQ_OP_READ, bh_end_read);
>  			continue;
>  		}
>  	}