Re: [PATCH] ocfs2: fix race between ocfs2_control_install_private() and ocfs2_control_release()

Andrew Morton <[email protected]> Mon, 1 Jun 2026 21:40:38 -0700
Newsgroups dev.linux.lists.ocfs2-devel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Tue, 2 Jun 2026 12:18:59 +0800 Heming Zhao <[email protected]> wrote:

> On Mon, Jun 01, 2026 at 08:16:18PM +0800, Joseph Qi wrote:
> > Move atomic_inc(&ocfs2_control_opened) and the handshake state update
> > inside ocfs2_control_lock to close a race window where
> > ocfs2_control_release() can observe ocfs2_control_opened dropping to
> > zero (resetting ocfs2_control_this_node and running_proto) while
> > ocfs2_control_install_private() is about to bump the counter and mark
> > the connection valid.
> > 
> > Fixes: 3cfd4ab6b6b4 ("ocfs2: Add the local node id to the handshake.")
> > Reported-by: Ginger <[email protected]>
> 
> The code looks good to me, but above email address is not valid.
> The correct should be: <[email protected]>

Updated, thanks.