Re: [PATCH v4 1/2] ocfs2: validate inline xattrs during inode block validation

Cen Zhang <[email protected]> Wed, 24 Jun 2026 18:25:27 +0800
Newsgroups dev.linux.lists.ocfs2-devel,org.kernel.vger.linux-kernel
Message-ID <CAFRLqsV23o0-ofFxJoLFMPMCgqs-NPYykhF70_w+MdjwgGiLQQ@mail.gmail.com>
Hi Joseph,

> Seems we can define a ocfs2_xattr_entry_type and pass in, then compute
> the size inside ocfs2_validate_xattr_entries().
> e.g.
>
> enum ocfs2_xattr_entry_type {
>         OCFS2_XATTR_IBODY,
>         OCFS2_XATTR_BLOCK,
>         OCFS2_XATTR_BUCKET
> };
>
> And here 'where' is to identify inline xattr, xattr block or bucket.
> Commonly, blkno is already sufficient to uniquely identifies the corrupt
> block. So I'd rather drop it for simplification.

Thanks for your review and suggestion.  I will rework this for v5.

Best regards,
Cen Zhang