arch/m68k/coldfire/m528x.c:113:21: error: implicit declaration of function 'read16'; did you mean 'ioread16'?

Hi Greg,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   94515f3a7d4256a5062176b7d6ed0471938cd51a
commit: e1f3a00670d13d1ed901125026c1f65394e670a5 m68k: coldfire: use ColdFire specifc IO access in SoC code
date:   6 weeks ago
config: m68k-randconfig-r073-20260718 (https://download.01.org/0day-ci/archive/20260718/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 11.5.0
smatch: v0.5.0-9185-gbcc58b9c
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260718/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: e1f3a00670d1 ("m68k: coldfire: use ColdFire specifc IO access in SoC code")
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   arch/m68k/coldfire/m528x.c:100:6: warning: no previous prototype for 'wildfire_halt' [-Wmissing-prototypes]
     100 | void wildfire_halt(void)
         |      ^~~~~~~~~~~~~
   arch/m68k/coldfire/m528x.c:108:6: warning: no previous prototype for 'wildfiremod_halt' [-Wmissing-prototypes]
     108 | void wildfiremod_halt(void)
         |      ^~~~~~~~~~~~~~~~
   In file included from arch/m68k/include/asm/io.h:6,
                    from include/linux/io.h:12,
                    from arch/m68k/coldfire/m528x.c:21:
   arch/m68k/coldfire/m528x.c: In function 'wildfiremod_halt':
>> arch/m68k/coldfire/m528x.c:113:21: error: implicit declaration of function 'read16'; did you mean 'ioread16'? [-Werror=implicit-function-declaration]
     113 |         mcf_write16(read16(MCFGPIO_PEPAR) & ~(1 << (5 * 2)), MCFGPIO_PEPAR);
         |                     ^~~~~~
   arch/m68k/include/asm/io_no.h:24:76: note: in definition of macro '__raw_writew'
      24 | #define __raw_writew(b, addr) (void)((*(__force volatile u16 *) (addr)) = (b))
         |                                                                            ^
   arch/m68k/coldfire/m528x.c:113:9: note: in expansion of macro 'mcf_write16'
     113 |         mcf_write16(read16(MCFGPIO_PEPAR) & ~(1 << (5 * 2)), MCFGPIO_PEPAR);
         |         ^~~~~~~~~~~
   arch/m68k/coldfire/m528x.c:116:20: error: implicit declaration of function 'read8'; did you mean 'readb'? [-Werror=implicit-function-declaration]
     116 |         mcf_write8(read8(MCFGPIO_PDDR_E) | (1 << 5), MCFGPIO_PDDR_E);
         |                    ^~~~~
   arch/m68k/include/asm/io_no.h:23:75: note: in definition of macro '__raw_writeb'
      23 | #define __raw_writeb(b, addr) (void)((*(__force volatile u8 *) (addr)) = (b))
         |                                                                           ^
   arch/m68k/coldfire/m528x.c:116:9: note: in expansion of macro 'mcf_write8'
     116 |         mcf_write8(read8(MCFGPIO_PDDR_E) | (1 << 5), MCFGPIO_PDDR_E);
         |         ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +113 arch/m68k/coldfire/m528x.c

   106	
   107	#ifdef CONFIG_WILDFIREMOD
   108	void wildfiremod_halt(void)
   109	{
   110		printk(KERN_INFO "WildFireMod hibernating...\n");
   111	
   112		/* Set portE.5 to Digital IO */
 > 113		mcf_write16(read16(MCFGPIO_PEPAR) & ~(1 << (5 * 2)), MCFGPIO_PEPAR);
   114	
   115		/* Make portE.5 an output */
   116		mcf_write8(read8(MCFGPIO_PDDR_E) | (1 << 5), MCFGPIO_PDDR_E);
   117	
   118		/* Now toggle portE.5 from low to high */
   119		mcf_write8(read8(MCFGPIO_PODR_E) & ~(1 << 5), MCFGPIO_PODR_E);
   120		mcf_write8(read8(MCFGPIO_PODR_E) | (1 << 5), MCFGPIO_PODR_E);
   121	
   122		printk(KERN_EMERG "Failed to hibernate. Halting!\n");
   123	}
   124	#endif
   125	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki