Re: [srini-nvmem:for-next 28/34] drivers/nvmem/mt6323-efuse.c:6:10: fatal error: linux/device-id/of.h: No such file or directory

On 7/18/26 4:39 PM, Roman Vivchar wrote:
> Hi,
> 
> On Friday, July 17th, 2026 at 7:55 PM, Andy Shevchenko <[email protected]> wrote:
> 
> ...
>  
>>>>> drivers/nvmem/mt6323-efuse.c:6:10: fatal error: linux/device-id/of.h: No such file or directory
>>>        6 | #include <linux/device-id/of.h>
>>>          |          ^~~~~~~~~~~~~~~~~~~~~~
>>>    compilation terminated.
>>
>> This header shouldn't be included explicitly. Now platform_device.h is
>> responsible for that. TL;DR: This inclusion should be simply dropped to
>> fix this.
> 
> Oh I see. This patch was based on the next-20260708, which has the
> mod_devicetable.h refactoring. Since nvmem/for-next doesn't have those
> yet, device-id/of.h is missing and simply dropping it still breaks the
> build because platform_device.h doesn't pull necessary definitions.
> 
> I don't think sending patch to restore mod_devicetable.h and then
> dropping it later is a good idea...
> 
> Srinivas, perhaps it's possible to drop the patch from the tree?
> I will resend the patch once dependencies land (and with dropped
> explicit device-id/of.h).
Sure, I will drop the patch now.

--srini
> 
> Best regards,
> Roman