Re: [char-misc:char-misc-testing 1/1] Diff in drivers/android/binder/thread.rs:1296:

Philip Li <[email protected]> Tue, 28 Jul 2026 13:21:30 +0800
Newsgroups dev.linux.lists.oe-kbuild-all
Message-ID <amg8Wqhs5paocBLl@rli9-mobl>
On Mon, Jul 27, 2026 at 09:29:48PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 27, 2026 at 06:01:47PM +0200, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
> > head:   0957fbab972a9499626ac457fd924b24491c6315
> > commit: 0957fbab972a9499626ac457fd924b24491c6315 [1/1] Merge 7.2-rc5 into char-misc-next
> > config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260727/[email protected]/config)
> > compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
> > rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260727/[email protected]/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <[email protected]>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    PATH=/opt/cross/clang-22/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> >    INFO PATH=/opt/cross/rustc-1.96.0-bindgen-0.72.1/cargo/bin:/opt/cross/clang-22/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> >    /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS=\ -fno-crash-diagnostics\ -Wno-error=return-type\ -Wreturn-type\ -funsigned-char\ -Wundef\ -falign-functions=64 W=1 --keep-going LLVM=1 -j384 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck 
> >    make: Entering directory '/kbuild/src'
> >    make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
> > >> Diff in drivers/android/binder/thread.rs:1296:
> >                                 ExtendedError::new(info.debug_id as u32, err.reply, source.to_errno());
> >                         }
> >     
> >    -                binder_debug!(
> >    -                    FailedTransaction,
> >    -                    "transaction {} to {}:{} failed {:?}, code {} size {}-{}",
> >    -                    if info.is_reply {
> >    -                        "reply"
> >    -                    } else if info.is_oneway() {
> >    -                        "async"
> >    -                    } else {
> >    -                        "call"
> >    -                    },
> >    -                    info.to_pid,
> >    -                    info.to_tid,
> >    -                    err,
> >    -                    info.code,
> >    -                    info.data_size,
> >    -                    info.offsets_size
> >    -                );
> >    +                    binder_debug!(
> >    +                        FailedTransaction,
> >    +                        "transaction {} to {}:{} failed {:?}, code {} size {}-{}",
> >    +                        if info.is_reply {
> >    +                            "reply"
> >    +                        } else if info.is_oneway() {
> >    +                            "async"
> >    +                        } else {
> >    +                            "call"
> >    +                        },
> >    +                        info.to_pid,
> >    +                        info.to_tid,
> >    +                        err,
> >    +                        info.code,
> >    +                        info.data_size,
> >    +                        info.offsets_size
> >    +                    );
> >                     }
> >                 }
> >             }
> 
> I don't understand these warnings, there was a merge in my tree, and I
> resolved it, so where does this "diff" come from?

Hi Greg, this is the result from rustfmtcheck, it sugggests the indent of
this binder_debug! is wrong, thus it shows the diff for the expected style.

Thanks

> 
> thanks,
> 
> greg k-h
>