[djwong-xfs:llm-fixes-24 132/140] fs/xfs/scrub/dir_repair.c:777:59: error: use of undeclared identifier 'ino'
kernel test robot <[email protected]> Wed, 29 Jul 2026 10:07:10 +0800
| Newsgroups | dev.linux.lists.oe-kbuild-all |
|---|---|
| Message-ID | <[email protected]> |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git llm-fixes-24 head: a0c02c40791d6f966d57e1054cb802a6016933c0 commit: c709e2bbff2c468b5adc159df3b51d3eddbe05a4 [132/140] xfs: be extra careful about replacement directory construction config: i386-buildonly-randconfig-005-20260729 (https://download.01.org/0day-ci/archive/20260729/[email protected]/config) compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260729/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): >> fs/xfs/scrub/dir_repair.c:777:59: error: use of undeclared identifier 'ino' 777 | error = xchk_dir_lookup(rd->sc, rd->sc->tempip, xname, &ino); | ^~~ fs/xfs/scrub/dir_repair.c:800:59: error: use of undeclared identifier 'ino' 800 | error = xchk_dir_lookup(rd->sc, rd->sc->tempip, xname, &ino); | ^~~ fs/xfs/scrub/dir_repair.c:806:7: error: use of undeclared identifier 'ino' 806 | if (ino != dirent->ino) { | ^~~ 3 errors generated. vim +/ino +777 fs/xfs/scrub/dir_repair.c 8559b21a64d9833 Darrick J. Wong 2024-04-22 741 b1991ee3e7cf852 Darrick J. Wong 2024-04-15 742 /* b1991ee3e7cf852 Darrick J. Wong 2024-04-15 743 * Add this stashed incore directory entry to the temporary directory. b1991ee3e7cf852 Darrick J. Wong 2024-04-15 744 * The caller must hold the tempdir's IOLOCK, must not hold any ILOCKs, and b1991ee3e7cf852 Darrick J. Wong 2024-04-15 745 * must not be in transaction context. b1991ee3e7cf852 Darrick J. Wong 2024-04-15 746 */ b1991ee3e7cf852 Darrick J. Wong 2024-04-15 747 STATIC int b1991ee3e7cf852 Darrick J. Wong 2024-04-15 748 xrep_dir_replay_update( b1991ee3e7cf852 Darrick J. Wong 2024-04-15 749 struct xrep_dir *rd, b1991ee3e7cf852 Darrick J. Wong 2024-04-15 750 const struct xfs_name *xname, b1991ee3e7cf852 Darrick J. Wong 2024-04-15 751 const struct xrep_dirent *dirent) b1991ee3e7cf852 Darrick J. Wong 2024-04-15 752 { b1991ee3e7cf852 Darrick J. Wong 2024-04-15 753 struct xfs_mount *mp = rd->sc->mp; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 754 #ifdef DEBUG b1991ee3e7cf852 Darrick J. Wong 2024-04-15 755 xfs_ino_t ino; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 756 #endif b1991ee3e7cf852 Darrick J. Wong 2024-04-15 757 uint resblks; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 758 int error; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 759 f1097be220fa938 Allison Henderson 2024-04-22 760 resblks = xfs_link_space_res(mp, xname->len); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 761 error = xchk_trans_alloc(rd->sc, resblks); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 762 if (error) b1991ee3e7cf852 Darrick J. Wong 2024-04-15 763 return error; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 764 b1991ee3e7cf852 Darrick J. Wong 2024-04-15 765 /* Lock the temporary directory and join it to the transaction */ b1991ee3e7cf852 Darrick J. Wong 2024-04-15 766 xrep_tempfile_ilock(rd->sc); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 767 xfs_trans_ijoin(rd->sc->tp, rd->sc->tempip, 0); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 768 8559b21a64d9833 Darrick J. Wong 2024-04-22 769 switch (dirent->action) { 8559b21a64d9833 Darrick J. Wong 2024-04-22 770 case XREP_DIRENT_ADD: b1991ee3e7cf852 Darrick J. Wong 2024-04-15 771 /* 8559b21a64d9833 Darrick J. Wong 2024-04-22 772 * Create a replacement dirent in the temporary directory. 8559b21a64d9833 Darrick J. Wong 2024-04-22 773 * Note that _createname doesn't check for existing entries. 8559b21a64d9833 Darrick J. Wong 2024-04-22 774 * There shouldn't be any in the temporary dir, but we'll 8559b21a64d9833 Darrick J. Wong 2024-04-22 775 * verify this in debug mode. b1991ee3e7cf852 Darrick J. Wong 2024-04-15 776 */ b1991ee3e7cf852 Darrick J. Wong 2024-04-15 @777 error = xchk_dir_lookup(rd->sc, rd->sc->tempip, xname, &ino); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 778 if (error != -ENOENT) { b1991ee3e7cf852 Darrick J. Wong 2024-04-15 779 ASSERT(error != -ENOENT); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 780 goto out_cancel; c709e2bbff2c468 Darrick J. Wong 2026-07-23 781 error = -EIO; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 782 } b1991ee3e7cf852 Darrick J. Wong 2024-04-15 783 8559b21a64d9833 Darrick J. Wong 2024-04-22 784 error = xrep_dir_replay_createname(rd, xname, dirent->ino, 8559b21a64d9833 Darrick J. Wong 2024-04-22 785 resblks); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 786 if (error) b1991ee3e7cf852 Darrick J. Wong 2024-04-15 787 goto out_cancel; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 788 b1991ee3e7cf852 Darrick J. Wong 2024-04-15 789 if (xname->type == XFS_DIR3_FT_DIR) b1991ee3e7cf852 Darrick J. Wong 2024-04-15 790 rd->subdirs++; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 791 rd->dirents++; 8559b21a64d9833 Darrick J. Wong 2024-04-22 792 break; 8559b21a64d9833 Darrick J. Wong 2024-04-22 793 case XREP_DIRENT_REMOVE: 8559b21a64d9833 Darrick J. Wong 2024-04-22 794 /* 8559b21a64d9833 Darrick J. Wong 2024-04-22 795 * Remove a dirent from the temporary directory. Note that 8559b21a64d9833 Darrick J. Wong 2024-04-22 796 * _removename doesn't check the inode target of the exist 8559b21a64d9833 Darrick J. Wong 2024-04-22 797 * entry. There should be a perfect match in the temporary 8559b21a64d9833 Darrick J. Wong 2024-04-22 798 * dir, but we'll verify this in debug mode. 8559b21a64d9833 Darrick J. Wong 2024-04-22 799 */ 8559b21a64d9833 Darrick J. Wong 2024-04-22 800 error = xchk_dir_lookup(rd->sc, rd->sc->tempip, xname, &ino); 8559b21a64d9833 Darrick J. Wong 2024-04-22 801 if (error) { 8559b21a64d9833 Darrick J. Wong 2024-04-22 802 ASSERT(error != 0); c709e2bbff2c468 Darrick J. Wong 2026-07-23 803 error = -EIO; 8559b21a64d9833 Darrick J. Wong 2024-04-22 804 goto out_cancel; 8559b21a64d9833 Darrick J. Wong 2024-04-22 805 } 8559b21a64d9833 Darrick J. Wong 2024-04-22 806 if (ino != dirent->ino) { 8559b21a64d9833 Darrick J. Wong 2024-04-22 807 ASSERT(ino == dirent->ino); 8559b21a64d9833 Darrick J. Wong 2024-04-22 808 error = -EIO; 8559b21a64d9833 Darrick J. Wong 2024-04-22 809 goto out_cancel; 8559b21a64d9833 Darrick J. Wong 2024-04-22 810 } 8559b21a64d9833 Darrick J. Wong 2024-04-22 811 8559b21a64d9833 Darrick J. Wong 2024-04-22 812 error = xrep_dir_replay_removename(rd, xname, resblks); 8559b21a64d9833 Darrick J. Wong 2024-04-22 813 if (error) 8559b21a64d9833 Darrick J. Wong 2024-04-22 814 goto out_cancel; 8559b21a64d9833 Darrick J. Wong 2024-04-22 815 8559b21a64d9833 Darrick J. Wong 2024-04-22 816 if (xname->type == XFS_DIR3_FT_DIR) 8559b21a64d9833 Darrick J. Wong 2024-04-22 817 rd->subdirs--; 8559b21a64d9833 Darrick J. Wong 2024-04-22 818 rd->dirents--; 8559b21a64d9833 Darrick J. Wong 2024-04-22 819 break; 8559b21a64d9833 Darrick J. Wong 2024-04-22 820 default: 8559b21a64d9833 Darrick J. Wong 2024-04-22 821 ASSERT(0); 8559b21a64d9833 Darrick J. Wong 2024-04-22 822 error = -EIO; 8559b21a64d9833 Darrick J. Wong 2024-04-22 823 goto out_cancel; 8559b21a64d9833 Darrick J. Wong 2024-04-22 824 } b1991ee3e7cf852 Darrick J. Wong 2024-04-15 825 b1991ee3e7cf852 Darrick J. Wong 2024-04-15 826 /* Commit and unlock. */ b1991ee3e7cf852 Darrick J. Wong 2024-04-15 827 error = xrep_trans_commit(rd->sc); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 828 if (error) b1991ee3e7cf852 Darrick J. Wong 2024-04-15 829 return error; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 830 b1991ee3e7cf852 Darrick J. Wong 2024-04-15 831 xrep_tempfile_iunlock(rd->sc); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 832 return 0; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 833 out_cancel: b1991ee3e7cf852 Darrick J. Wong 2024-04-15 834 xchk_trans_cancel(rd->sc); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 835 xrep_tempfile_iunlock(rd->sc); b1991ee3e7cf852 Darrick J. Wong 2024-04-15 836 return error; b1991ee3e7cf852 Darrick J. Wong 2024-04-15 837 } b1991ee3e7cf852 Darrick J. Wong 2024-04-15 838 :::::: The code at line 777 was first introduced by commit :::::: b1991ee3e7cf852e95a3498801303cfbb4468681 xfs: online repair of directories :::::: TO: Darrick J. Wong <[email protected]> :::::: CC: Darrick J. Wong <[email protected]> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki