RE: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret'

"Holalu Yogendra, Niranjan" <[email protected]> Wed, 29 Jul 2026 09:56:57 +0000

Newsgroups	dev.linux.lists.oe-kbuild-all,dev.linux.lists.oe-kbuild,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

> On 11:16-20260729, Dan Carpenter wrote:
> Subject: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret's
> 
> smatch warnings:
> sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error
> code 'ret'
> 
> vim +/ret +984 sound/soc/codecs/tac5xx2-sdw.c
> 
> 38c89fededd5a9 Niranjan H Y 2026-05-05   979  static int tac5xx2_jack_init(struct tac5xx2_prv *tac_dev)
> 38c89fededd5a9 Niranjan H Y 2026-05-05   980  {
> 38c89fededd5a9 Niranjan H Y 2026-05-05   981  	int ret = 0;
> 38c89fededd5a9 Niranjan H Y 2026-05-05   982
> 38c89fededd5a9 Niranjan H Y 2026-05-05   983  	if (!tac_dev->hs_jack)
> 38c89fededd5a9 Niranjan H Y 2026-05-05  @984  		goto disable_interrupts;
> 
> Is this supposed to be an error path?  tac_dev->hs_jack can't be NULL
> in real life.

We added this as defensive strategy in case someone calls like this
   snd_soc_component_set_jack(component, NULL, NULL);

Regards
Niranjan