Re: [paulmckrcu:dev 36/44] arch/x86/kernel/nmi.c:88:15: sparse: sparse: symbol 'toolong_nmi_panic' was not declared. Should it be static?

On Fri, Jul 31, 2026 at 01:44:25AM +0800, kernel test robot wrote:
> tree:   https://github.com/paulmckrcu/linux dev
> head:   9df1c10e4ddffa50d054112facefa25376c7a219
> commit: 2203ef58a5e3cd2a8b4879488d25a52afebaf64f [36/44] x86/nmi: Enable panic() when NMI handler runs too long
> config: i386-randconfig-r131-20260730 (https://download.01.org/0day-ci/archive/20260731/[email protected]/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> sparse: v0.6.5-rc1
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260731/[email protected]/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> 
> sparse warnings: (new ones prefixed by >>)
> >> arch/x86/kernel/nmi.c:88:15: sparse: sparse: symbol 'toolong_nmi_panic' was not declared. Should it be static?
> 
> vim +/toolong_nmi_panic +88 arch/x86/kernel/nmi.c
> 
>     86	
>     87	int unknown_nmi_panic;
>   > 88	unsigned long toolong_nmi_panic = 0;
>     89	int panic_on_unrecovered_nmi;
>     90	int panic_on_io_nmi;
>     91	

Good catch, and I will fix on my next rebase.

							Thanx, Paul