net/xfrm/xfrm_state.c:1220: Warning: missing closing `"'
kernel test robot <[email protected]> Mon, 03 Aug 2026 06:26:11 +0800
| Newsgroups | dev.linux.lists.oe-kbuild-all,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Jakub, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: bd1dde877520385f6638af2d0f2bd4f212eb8f34 commit: e9deb406c10f5a73bcfd62f42ca1187b220bc188 Merge tag 'ipsec-2026-06-22' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec date: 6 weeks ago config: s390-randconfig-r062-20260802 (https://download.01.org/0day-ci/archive/20260803/[email protected]/config) compiler: s390-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260803/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: e9deb406c10f ("Merge tag 'ipsec-2026-06-22' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): net/xfrm/xfrm_state.c: Assembler messages: >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' >> net/xfrm/xfrm_state.c:1220: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' net/xfrm/xfrm_state.c:1225: Warning: missing closing `"' vim +1220 net/xfrm/xfrm_state.c edcd582152090b David S. Miller 2006-08-24 1200 81a331a0e72ddc Steffen Klassert 2024-10-23 1201 struct xfrm_state *xfrm_input_state_lookup(struct net *net, u32 mark, 81a331a0e72ddc Steffen Klassert 2024-10-23 1202 const xfrm_address_t *daddr, 81a331a0e72ddc Steffen Klassert 2024-10-23 1203 __be32 spi, u8 proto, 81a331a0e72ddc Steffen Klassert 2024-10-23 1204 unsigned short family) 81a331a0e72ddc Steffen Klassert 2024-10-23 1205 { e952837f3ddb0f Florian Westphal 2024-11-28 1206 struct xfrm_hash_state_ptrs state_ptrs; 81a331a0e72ddc Steffen Klassert 2024-10-23 1207 struct hlist_head *state_cache_input; 81a331a0e72ddc Steffen Klassert 2024-10-23 1208 struct xfrm_state *x = NULL; 81a331a0e72ddc Steffen Klassert 2024-10-23 1209 ddd3d013292031 Herbert Xu 2026-06-12 1210 /* BH is always disabled on the input path. */ ddd3d013292031 Herbert Xu 2026-06-12 1211 lockdep_assert_in_softirq(); ddd3d013292031 Herbert Xu 2026-06-12 1212 6c9b7db96db62e Sebastian Sewior 2025-01-23 1213 state_cache_input = raw_cpu_ptr(net->xfrm.state_cache_input); 81a331a0e72ddc Steffen Klassert 2024-10-23 1214 81a331a0e72ddc Steffen Klassert 2024-10-23 1215 hlist_for_each_entry_rcu(x, state_cache_input, state_cache_input) { 81a331a0e72ddc Steffen Klassert 2024-10-23 1216 if (x->props.family != family || 81a331a0e72ddc Steffen Klassert 2024-10-23 1217 x->id.spi != spi || 81a331a0e72ddc Steffen Klassert 2024-10-23 1218 x->id.proto != proto || 81a331a0e72ddc Steffen Klassert 2024-10-23 1219 !xfrm_addr_equal(&x->id.daddr, daddr, family)) 81a331a0e72ddc Steffen Klassert 2024-10-23 @1220 continue; 81a331a0e72ddc Steffen Klassert 2024-10-23 1221 81a331a0e72ddc Steffen Klassert 2024-10-23 1222 if ((mark & x->mark.m) != x->mark.v) 81a331a0e72ddc Steffen Klassert 2024-10-23 1223 continue; 81a331a0e72ddc Steffen Klassert 2024-10-23 1224 if (!xfrm_state_hold_rcu(x)) 81a331a0e72ddc Steffen Klassert 2024-10-23 1225 continue; 81a331a0e72ddc Steffen Klassert 2024-10-23 1226 goto out; 81a331a0e72ddc Steffen Klassert 2024-10-23 1227 } 81a331a0e72ddc Steffen Klassert 2024-10-23 1228 e952837f3ddb0f Florian Westphal 2024-11-28 1229 xfrm_hash_ptrs_get(net, &state_ptrs); e952837f3ddb0f Florian Westphal 2024-11-28 1230 e952837f3ddb0f Florian Westphal 2024-11-28 1231 x = __xfrm_state_lookup(&state_ptrs, mark, daddr, spi, proto, family); ddd3d013292031 Herbert Xu 2026-06-12 1232 if (x) { ddd3d013292031 Herbert Xu 2026-06-12 1233 spin_lock(&net->xfrm.xfrm_state_lock); ddd3d013292031 Herbert Xu 2026-06-12 1234 if (x->km.state != XFRM_STATE_VALID) { ddd3d013292031 Herbert Xu 2026-06-12 1235 /* ddd3d013292031 Herbert Xu 2026-06-12 1236 * The state is about to be destroyed. ddd3d013292031 Herbert Xu 2026-06-12 1237 * ddd3d013292031 Herbert Xu 2026-06-12 1238 * Don't add it to the cache but still ddd3d013292031 Herbert Xu 2026-06-12 1239 * return it to the caller. ddd3d013292031 Herbert Xu 2026-06-12 1240 */ ddd3d013292031 Herbert Xu 2026-06-12 1241 } else if (hlist_unhashed(&x->state_cache_input)) { 81a331a0e72ddc Steffen Klassert 2024-10-23 1242 hlist_add_head_rcu(&x->state_cache_input, state_cache_input); 81a331a0e72ddc Steffen Klassert 2024-10-23 1243 } else { 81a331a0e72ddc Steffen Klassert 2024-10-23 1244 hlist_del_rcu(&x->state_cache_input); 81a331a0e72ddc Steffen Klassert 2024-10-23 1245 hlist_add_head_rcu(&x->state_cache_input, state_cache_input); 81a331a0e72ddc Steffen Klassert 2024-10-23 1246 } ddd3d013292031 Herbert Xu 2026-06-12 1247 spin_unlock(&net->xfrm.xfrm_state_lock); 81a331a0e72ddc Steffen Klassert 2024-10-23 1248 } 81a331a0e72ddc Steffen Klassert 2024-10-23 1249 81a331a0e72ddc Steffen Klassert 2024-10-23 1250 out: 81a331a0e72ddc Steffen Klassert 2024-10-23 1251 return x; 81a331a0e72ddc Steffen Klassert 2024-10-23 1252 } 81a331a0e72ddc Steffen Klassert 2024-10-23 1253 EXPORT_SYMBOL(xfrm_input_state_lookup); 81a331a0e72ddc Steffen Klassert 2024-10-23 1254 :::::: The code at line 1220 was first introduced by commit :::::: 81a331a0e72ddc2f75092603d9577bd1a0ca23ad xfrm: Add an inbound percpu state cache. :::::: TO: Steffen Klassert <[email protected]> :::::: CC: Steffen Klassert <[email protected]> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki