Re: [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume

Hi Shih-Yuan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on linus/master v7.2-rc6 next-20260804]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shih-Yuan-Lee/spi-pxa2xx-disable-DMA-and-fix-runtime-PM-for-Apple-MacBook8-1/20260804-222537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20260717163731.6782-3-fourdollars%40debian.org
patch subject: [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume
config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20260805/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260805/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

   drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_resume':
>> drivers/spi/spi-pxa2xx.c:1554:28: warning: unused variable 'ssp' [-Wunused-variable]
    1554 |         struct ssp_device *ssp = drv_data->ssp;
         |                            ^~~


vim +/ssp +1554 drivers/spi/spi-pxa2xx.c

e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1550  
86d2593afeb94e drivers/spi/pxa2xx_spi.c Mike Rapoport   2009-07-21  1551  static int pxa2xx_spi_resume(struct device *dev)
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1552  {
86d2593afeb94e drivers/spi/pxa2xx_spi.c Mike Rapoport   2009-07-21  1553  	struct driver_data *drv_data = dev_get_drvdata(dev);
2f1a74e5a2de04 drivers/spi/pxa2xx_spi.c eric miao       2007-11-21 @1554  	struct ssp_device *ssp = drv_data->ssp;
bffc967e93c771 drivers/spi/spi-pxa2xx.c Jarkko Nikula   2016-09-07  1555  	int status;
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1556  
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1557  	/* Enable the SSP clock */
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1558  	if (!pm_runtime_suspended(dev)) {
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1559  		status = pxa2xx_spi_clk_enable(drv_data);
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1560  		if (status)
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1561  			return status;
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1562  	}
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1563  
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1564  	drv_data->suspended = false;
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1565  
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1566  	/* Start the queue running */
51eea52d26d493 drivers/spi/spi-pxa2xx.c Lubomir Rintel  2019-01-16  1567  	return spi_controller_resume(drv_data->controller);
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1568  }
7d94a505858841 drivers/spi/spi-pxa2xx.c Mika Westerberg 2013-01-22  1569  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki