Re: [PATCH] net: sysfs: cleanup coding style

Hi Lucas,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main brauner-vfs/vfs.all linus/master v7.2-rc6 next-20260804]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lucas-Poupeau/net-sysfs-cleanup-coding-style/20260805-152318
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260628185824.231250-1-lucasp.linux%40gmail.com
patch subject: [PATCH] net: sysfs: cleanup coding style
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20260805/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260805/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/dma-mapping.h:5,
                    from include/linux/skbuff.h:28,
                    from include/net/net_namespace.h:44,
                    from include/linux/netdevice.h:38,
                    from net/core/net-sysfs.c:10:
>> net/core/net-sysfs.c:622:23: error: 'netdev_group_show' undeclared here (not in a function); did you mean 'netdev_show'?
     622 | static DEVICE_ATTR_RW(netdev_group);
         |                       ^~~~~~~~~~~~
   include/linux/device.h:173:36: note: in definition of macro '__DEVICE_ATTR_SHOW_STORE'
     173 |         .show           = _Generic(_show,                                               \
         |                                    ^~~~~
   include/linux/device.h:201:9: note: in expansion of macro '__DEVICE_ATTR'
     201 |         __DEVICE_ATTR(_name, _mode, _name##_show, _name##_store)
         |         ^~~~~~~~~~~~~
   include/linux/device.h:204:9: note: in expansion of macro '__DEVICE_ATTR_RW_MODE'
     204 |         __DEVICE_ATTR_RW_MODE(_name, 0644)
         |         ^~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:246:52: note: in expansion of macro '__DEVICE_ATTR_RW'
     246 |         struct device_attribute dev_attr_##_name = __DEVICE_ATTR_RW(_name)
         |                                                    ^~~~~~~~~~~~~~~~
   net/core/net-sysfs.c:622:8: note: in expansion of macro 'DEVICE_ATTR_RW'
     622 | static DEVICE_ATTR_RW(netdev_group);
         |        ^~~~~~~~~~~~~~
>> net/core/net-sysfs.c:622:23: error: 'netdev_group_store' undeclared here (not in a function); did you mean 'netdev_lock_store'?
     622 | static DEVICE_ATTR_RW(netdev_group);
         |                       ^~~~~~~~~~~~
   include/linux/device.h:177:36: note: in definition of macro '__DEVICE_ATTR_SHOW_STORE'
     177 |         .store          = _Generic(_store,                                              \
         |                                    ^~~~~~
   include/linux/device.h:201:9: note: in expansion of macro '__DEVICE_ATTR'
     201 |         __DEVICE_ATTR(_name, _mode, _name##_show, _name##_store)
         |         ^~~~~~~~~~~~~
   include/linux/device.h:204:9: note: in expansion of macro '__DEVICE_ATTR_RW_MODE'
     204 |         __DEVICE_ATTR_RW_MODE(_name, 0644)
         |         ^~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:246:52: note: in expansion of macro '__DEVICE_ATTR_RW'
     246 |         struct device_attribute dev_attr_##_name = __DEVICE_ATTR_RW(_name)
         |                                                    ^~~~~~~~~~~~~~~~
   net/core/net-sysfs.c:622:8: note: in expansion of macro 'DEVICE_ATTR_RW'
     622 | static DEVICE_ATTR_RW(netdev_group);
         |        ^~~~~~~~~~~~~~
>> net/core/net-sysfs.c:621:16: warning: 'group_show' defined but not used [-Wunused-function]
     621 | NETDEVICE_SHOW(group, fmt_dec);
         |                ^~~~~
   net/core/net-sysfs.c:143:16: note: in definition of macro 'NETDEVICE_SHOW'
     143 | static ssize_t field##_show(struct device *dev,                         \
         |                ^~~~~
>> net/core/net-sysfs.c:615:16: warning: 'group_store' defined but not used [-Wunused-function]
     615 | static ssize_t group_store(struct device *dev, struct device_attribute *attr,
         |                ^~~~~~~~~~~


vim +622 net/core/net-sysfs.c

   614	
 > 615	static ssize_t group_store(struct device *dev, struct device_attribute *attr,
   616				   const char *buf, size_t len)
   617	{
   618		return netdev_store(dev, attr, buf, len, change_group);
   619	}
   620	
 > 621	NETDEVICE_SHOW(group, fmt_dec);
 > 622	static DEVICE_ATTR_RW(netdev_group);
   623	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki