Re: [PATCH] net: sysfs: cleanup coding style

Hi Lucas,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main brauner-vfs/vfs.all linus/master v7.2-rc6 next-20260805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lucas-Poupeau/net-sysfs-cleanup-coding-style/20260805-152318
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260628185824.231250-1-lucasp.linux%40gmail.com
patch subject: [PATCH] net: sysfs: cleanup coding style
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260805/[email protected]/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260805/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> net/core/net-sysfs.c:622:8: error: use of undeclared identifier 'netdev_group_show'
     622 | static DEVICE_ATTR_RW(netdev_group);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:246:45: note: expanded from macro 'DEVICE_ATTR_RW'
     246 |         struct device_attribute dev_attr_##_name = __DEVICE_ATTR_RW(_name)
         |                                                    ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:204:2: note: expanded from macro '__DEVICE_ATTR_RW'
     204 |         __DEVICE_ATTR_RW_MODE(_name, 0644)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:201:30: note: expanded from macro '__DEVICE_ATTR_RW_MODE'
     201 |         __DEVICE_ATTR(_name, _mode, _name##_show, _name##_store)
         |                                     ^~~~~~~~~~~~
   <scratch space>:22:1: note: expanded from here
      22 | netdev_group_show
         | ^~~~~~~~~~~~~~~~~
>> net/core/net-sysfs.c:622:8: error: use of undeclared identifier 'netdev_group_store'; did you mean 'netdev_lock_store'?
     622 | static DEVICE_ATTR_RW(netdev_group);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:246:45: note: expanded from macro 'DEVICE_ATTR_RW'
     246 |         struct device_attribute dev_attr_##_name = __DEVICE_ATTR_RW(_name)
         |                                                    ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:204:2: note: expanded from macro '__DEVICE_ATTR_RW'
     204 |         __DEVICE_ATTR_RW_MODE(_name, 0644)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:201:44: note: expanded from macro '__DEVICE_ATTR_RW_MODE'
     201 |         __DEVICE_ATTR(_name, _mode, _name##_show, _name##_store)
         |                                                   ^~~~~~~~~~~~~
   <scratch space>:23:1: note: expanded from here
      23 | netdev_group_store
         | ^~~~~~~~~~~~~~~~~~
   net/core/net-sysfs.c:189:1: note: 'netdev_lock_store' declared here
     189 | netdev_lock_store(struct device *dev, struct device_attribute *attr,
         | ^
   net/core/net-sysfs.c:622:8: error: use of undeclared identifier 'netdev_group_store'
     622 | static DEVICE_ATTR_RW(netdev_group);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:246:45: note: expanded from macro 'DEVICE_ATTR_RW'
     246 |         struct device_attribute dev_attr_##_name = __DEVICE_ATTR_RW(_name)
         |                                                    ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:204:2: note: expanded from macro '__DEVICE_ATTR_RW'
     204 |         __DEVICE_ATTR_RW_MODE(_name, 0644)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:201:44: note: expanded from macro '__DEVICE_ATTR_RW_MODE'
     201 |         __DEVICE_ATTR(_name, _mode, _name##_show, _name##_store)
         |                                                   ^~~~~~~~~~~~~
   <scratch space>:23:1: note: expanded from here
      23 | netdev_group_store
         | ^~~~~~~~~~~~~~~~~~
   3 errors generated.


vim +/netdev_group_show +622 net/core/net-sysfs.c

   620	
   621	NETDEVICE_SHOW(group, fmt_dec);
 > 622	static DEVICE_ATTR_RW(netdev_group);
   623	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki