Re: [PATCH] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics

kernel test robot <[email protected]>
Newsgroups dev.linux.lists.oe-kbuild-all,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Mirza,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Mirza-Ishan-Beg/staging-rtl8723bs-refactor-traffic_stat-access-in-collect_traffic_statistics/20260806-062100
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260803144826.15980-1-seedandsyntax%40gmail.com
patch subject: [PATCH] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics
config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20260807/[email protected]/config)
compiler: csky-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260807/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'collect_traffic_statistics':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:1112:35: error: initialization of 'struct traffic_stat *' from incompatible pointer type 'struct rtw_traffic_statistics *' [-Wincompatible-pointer-types]
    1112 |         struct traffic_stat *ts = &pdvobjpriv->traffic_stat
         |                                   ^
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:1115:9: error: expected ',' or ';' before 'ts'
    1115 |         ts->tx_bytes = padapter->xmitpriv.tx_bytes;
         |         ^~
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:1116:11: error: invalid use of undefined type 'struct traffic_stat'
    1116 |         ts->tx_pkts = padapter->xmitpriv.tx_pkts;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1117:11: error: invalid use of undefined type 'struct traffic_stat'
    1117 |         ts->tx_drop = padapter->xmitpriv.tx_drop;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1120:11: error: invalid use of undefined type 'struct traffic_stat'
    1120 |         ts->rx_bytes = padapter->recvpriv.rx_bytes;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1121:11: error: invalid use of undefined type 'struct traffic_stat'
    1121 |         ts->rx_pkts = padapter->recvpriv.rx_pkts;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1122:11: error: invalid use of undefined type 'struct traffic_stat'
    1122 |         ts->rx_drop = padapter->recvpriv.rx_drop;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1125:11: error: invalid use of undefined type 'struct traffic_stat'
    1125 |         ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1125:30: error: invalid use of undefined type 'struct traffic_stat'
    1125 |         ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes;
         |                              ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1125:45: error: invalid use of undefined type 'struct traffic_stat'
    1125 |         ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes;
         |                                             ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1126:11: error: invalid use of undefined type 'struct traffic_stat'
    1126 |         ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1126:30: error: invalid use of undefined type 'struct traffic_stat'
    1126 |         ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes;
         |                              ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1126:45: error: invalid use of undefined type 'struct traffic_stat'
    1126 |         ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes;
         |                                             ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1127:11: error: invalid use of undefined type 'struct traffic_stat'
    1127 |         ts->last_tx_bytes = ts->tx_bytes;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1127:31: error: invalid use of undefined type 'struct traffic_stat'
    1127 |         ts->last_tx_bytes = ts->tx_bytes;
         |                               ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1128:11: error: invalid use of undefined type 'struct traffic_stat'
    1128 |         ts->last_rx_bytes = ts->rx_bytes;
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1128:31: error: invalid use of undefined type 'struct traffic_stat'
    1128 |         ts->last_rx_bytes = ts->rx_bytes;
         |                               ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1130:11: error: invalid use of undefined type 'struct traffic_stat'
    1130 |         ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024);
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1130:33: error: invalid use of undefined type 'struct traffic_stat'
    1130 |         ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024);
         |                                 ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1131:11: error: invalid use of undefined type 'struct traffic_stat'
    1131 |         ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024);
         |           ^~
   drivers/staging/rtl8723bs/core/rtw_cmd.c:1131:33: error: invalid use of undefined type 'struct traffic_stat'
    1131 |         ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024);
         |                                 ^~


vim +1112 drivers/staging/rtl8723bs/core/rtw_cmd.c

  1108	
  1109	static void collect_traffic_statistics(struct adapter *padapter)
  1110	{
  1111		struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
> 1112		struct traffic_stat *ts = &pdvobjpriv->traffic_stat
  1113	
  1114		/*  Tx */
> 1115		ts->tx_bytes = padapter->xmitpriv.tx_bytes;
> 1116		ts->tx_pkts = padapter->xmitpriv.tx_pkts;
  1117		ts->tx_drop = padapter->xmitpriv.tx_drop;
  1118	
  1119		/*  Rx */
  1120		ts->rx_bytes = padapter->recvpriv.rx_bytes;
  1121		ts->rx_pkts = padapter->recvpriv.rx_pkts;
  1122		ts->rx_drop = padapter->recvpriv.rx_drop;
  1123	
  1124		/*  Calculate throughput in last interval */
  1125		ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes;
  1126		ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes;
  1127		ts->last_tx_bytes = ts->tx_bytes;
  1128		ts->last_rx_bytes = ts->rx_bytes;
  1129	
  1130		ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024);
  1131		ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024);
  1132	}
  1133	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.