[zen:7.1/prjc 636/719] kernel/trace/rv/monitors/deadline/deadline.h:75:1: warning: control reaches end of non-void function
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild-all |
|---|---|
| Message-ID | <[email protected]> |
Hi Alfred, FYI, the error/warning still remains. tree: https://github.com/zen-kernel/zen-kernel 7.1/prjc head: bafe3c105f696e656e6f216bd7c2a76c373f2086 commit: de41db545b89a8e1f708de3813fec4a38d17f710 [636/719] sched/alt: [Sync] deadline sync-up fix config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260807/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260807/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): kernel/trace/rv/monitors/deadline/deadline.h: In function 'handle_newtask': kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/deadline/deadline.h:194:35: note: in expansion of macro 'EXPAND_ID_TASK' 194 | da_create_storage(EXPAND_ID_TASK(task), NULL); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/deadline/deadline.h:194:35: note: in expansion of macro 'EXPAND_ID_TASK' 194 | da_create_storage(EXPAND_ID_TASK(task), NULL); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h: In function 'handle_exit': kernel/trace/rv/monitors/deadline/deadline.h:200:52: error: 'struct task_struct' has no member named 'dl' 200 | da_destroy_storage(get_entity_id(&p->dl, DL_TASK, DL_TASK)); | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c: In function 'ha_get_env': kernel/trace/rv/monitors/nomiss/nomiss.c:43:25: error: implicit declaration of function 'dl_is_implicit' [-Wimplicit-function-declaration] 43 | return !dl_is_implicit(ha_get_target(ha_mon)); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/nomiss/nomiss.c: In function 'handle_sched_switch': kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:179:33: note: in expansion of macro 'EXPAND_ID_TASK' 179 | da_handle_event(EXPAND_ID_TASK(prev), sched_switch_suspend_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:179:33: note: in expansion of macro 'EXPAND_ID_TASK' 179 | da_handle_event(EXPAND_ID_TASK(prev), sched_switch_suspend_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:181:43: note: in expansion of macro 'EXPAND_ID_TASK' 181 | da_handle_start_run_event(EXPAND_ID_TASK(next), sched_switch_in_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:181:43: note: in expansion of macro 'EXPAND_ID_TASK' 181 | da_handle_start_run_event(EXPAND_ID_TASK(next), sched_switch_in_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/nomiss/nomiss.c:189:17: error: 'struct task_struct' has no member named 'dl_server' 189 | if (next->dl_server) | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:190:53: error: 'struct task_struct' has no member named 'dl_server' 190 | da_handle_start_event(EXPAND_ID(next->dl_server, cpu, | ^~ kernel/trace/rv/monitors/deadline/deadline.h:84:51: note: in definition of macro 'EXPAND_ID' 84 | #define EXPAND_ID(dl_se, cpu, type) get_entity_id(dl_se, cpu, type), dl_se | ^~~~~ kernel/trace/rv/monitors/nomiss/nomiss.c:190:53: error: 'struct task_struct' has no member named 'dl_server' 190 | da_handle_start_event(EXPAND_ID(next->dl_server, cpu, | ^~ kernel/trace/rv/monitors/deadline/deadline.h:84:70: note: in definition of macro 'EXPAND_ID' 84 | #define EXPAND_ID(dl_se, cpu, type) get_entity_id(dl_se, cpu, type), dl_se | ^~~~~ kernel/trace/rv/monitors/nomiss/nomiss.c: In function 'handle_sys_enter': kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:215:26: note: in expansion of macro 'EXPAND_ID_TASK' 215 | da_reset(EXPAND_ID_TASK(p)); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:215:26: note: in expansion of macro 'EXPAND_ID_TASK' 215 | da_reset(EXPAND_ID_TASK(p)); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:217:34: note: in expansion of macro 'EXPAND_ID_TASK' 217 | da_create_or_get(EXPAND_ID_TASK(p)); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:217:34: note: in expansion of macro 'EXPAND_ID_TASK' 217 | da_create_or_get(EXPAND_ID_TASK(p)); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/nomiss/nomiss.c: In function 'handle_sched_wakeup': kernel/trace/rv/monitors/deadline/deadline.h:85:47: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:223:33: note: in expansion of macro 'EXPAND_ID_TASK' 223 | da_handle_event(EXPAND_ID_TASK(tsk), sched_wakeup_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h:85:82: error: 'struct task_struct' has no member named 'dl' 85 | #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl | ^~ kernel/trace/rv/monitors/nomiss/nomiss.c:223:33: note: in expansion of macro 'EXPAND_ID_TASK' 223 | da_handle_event(EXPAND_ID_TASK(tsk), sched_wakeup_nomiss); | ^~~~~~~~~~~~~~ kernel/trace/rv/monitors/deadline/deadline.h: In function 'get_entity_id': >> kernel/trace/rv/monitors/deadline/deadline.h:75:1: warning: control reaches end of non-void function [-Wreturn-type] 75 | } | ^ vim +75 kernel/trace/rv/monitors/deadline/deadline.h b133207deb7260 Gabriele Monaco 2026-03-30 48 b133207deb7260 Gabriele Monaco 2026-03-30 49 /* b133207deb7260 Gabriele Monaco 2026-03-30 50 * Use negative numbers for the server. b133207deb7260 Gabriele Monaco 2026-03-30 51 * Currently only one fair server per CPU, may change in the future. b133207deb7260 Gabriele Monaco 2026-03-30 52 */ b133207deb7260 Gabriele Monaco 2026-03-30 53 #define fair_server_id(cpu) (-cpu) b133207deb7260 Gabriele Monaco 2026-03-30 54 #define ext_server_id(cpu) (-cpu - num_possible_cpus()) b133207deb7260 Gabriele Monaco 2026-03-30 55 #define NO_SERVER_ID (-2 * num_possible_cpus()) b133207deb7260 Gabriele Monaco 2026-03-30 56 /* b133207deb7260 Gabriele Monaco 2026-03-30 57 * Get a unique id used for dl entities b133207deb7260 Gabriele Monaco 2026-03-30 58 * b133207deb7260 Gabriele Monaco 2026-03-30 59 * The cpu is not required for tasks as the pid is used there, if this function b133207deb7260 Gabriele Monaco 2026-03-30 60 * is called on a dl_se that for sure corresponds to a task, DL_TASK can be b133207deb7260 Gabriele Monaco 2026-03-30 61 * used in place of cpu. b133207deb7260 Gabriele Monaco 2026-03-30 62 * We need the cpu for servers as it is provided in the tracepoint and we b133207deb7260 Gabriele Monaco 2026-03-30 63 * cannot easily retrieve it from the dl_se (requires the struct rq definition). b133207deb7260 Gabriele Monaco 2026-03-30 64 */ b133207deb7260 Gabriele Monaco 2026-03-30 65 static inline int get_entity_id(struct sched_dl_entity *dl_se, int cpu, u8 type) b133207deb7260 Gabriele Monaco 2026-03-30 66 { b133207deb7260 Gabriele Monaco 2026-03-30 67 if (dl_server(dl_se) && type != DL_TASK) { b133207deb7260 Gabriele Monaco 2026-03-30 68 if (type == DL_SERVER_FAIR) b133207deb7260 Gabriele Monaco 2026-03-30 69 return fair_server_id(cpu); b133207deb7260 Gabriele Monaco 2026-03-30 70 if (type == DL_SERVER_EXT) b133207deb7260 Gabriele Monaco 2026-03-30 71 return ext_server_id(cpu); b133207deb7260 Gabriele Monaco 2026-03-30 72 return NO_SERVER_ID; b133207deb7260 Gabriele Monaco 2026-03-30 73 } b133207deb7260 Gabriele Monaco 2026-03-30 74 return dl_task_of(dl_se)->pid; b133207deb7260 Gabriele Monaco 2026-03-30 @75 } b133207deb7260 Gabriele Monaco 2026-03-30 76 b133207deb7260 Gabriele Monaco 2026-03-30 77 static inline bool task_is_scx_enabled(struct task_struct *tsk) b133207deb7260 Gabriele Monaco 2026-03-30 78 { b133207deb7260 Gabriele Monaco 2026-03-30 79 return IS_ENABLED(CONFIG_SCHED_CLASS_EXT) && b133207deb7260 Gabriele Monaco 2026-03-30 80 tsk->sched_class == rv_ext_sched_class; b133207deb7260 Gabriele Monaco 2026-03-30 81 } b133207deb7260 Gabriele Monaco 2026-03-30 82 b133207deb7260 Gabriele Monaco 2026-03-30 83 /* Expand id and target as arguments for da functions */ b133207deb7260 Gabriele Monaco 2026-03-30 84 #define EXPAND_ID(dl_se, cpu, type) get_entity_id(dl_se, cpu, type), dl_se b133207deb7260 Gabriele Monaco 2026-03-30 @85 #define EXPAND_ID_TASK(tsk) get_entity_id(&tsk->dl, task_cpu(tsk), DL_TASK), &tsk->dl b133207deb7260 Gabriele Monaco 2026-03-30 86 :::::: The code at line 75 was first introduced by commit :::::: b133207deb72609ad4da40c4d50128a5e150677b rv: Add nomiss deadline monitor :::::: TO: Gabriele Monaco <[email protected]> :::::: CC: Gabriele Monaco <[email protected]> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki