[asahilinux:bits/240-isp 65/67] drivers/media/platform/apple/avd/avd-av1.c:586:47: warning: suggest parentheses around arithmetic in operand of '|'

tree:   https://github.com/AsahiLinux/linux bits/240-isp
head:   6b01d08e5d4d33d4a7cdfb1ecea6f78e295bfd75
commit: 0d6dcb9b11b41af215b8a8443b0e3f7d5aa6c110 [65/67] media: apple: avd: add av1 support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260809/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260809/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

   In file included from drivers/media/platform/apple/avd/avd-av1.c:27:
   drivers/media/platform/apple/avd/avd-av1.c: In function 'set_refs':
   drivers/media/platform/apple/avd/avd-av1.c:115:33: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
     115 | #define AV1_GM_TYPE(v)          FIELD_PREP(GENMASK(31, 30), v)
         |                                 ^~~~~~~~~~
   drivers/media/platform/apple/avd/avd-inst.h:195:41: note: in definition of macro 'push'
     195 | #define push(inst, name) push(avd, ctx, inst)
         |                                         ^~~~
   drivers/media/platform/apple/avd/avd-av1.c:315:30: note: in expansion of macro 'AV1_GM_TYPE'
     315 |                         push(AV1_GM_TYPE(gm->type[ref_idx]) |
         |                              ^~~~~~~~~~~
   drivers/media/platform/apple/avd/avd-av1.c: In function 'set_header':
>> drivers/media/platform/apple/avd/avd-av1.c:586:47: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     586 |                         frame->upscaled_width - 1, "upscaled_width");
         |                         ~~~~~~~~~~~~~~~~~~~~~~^~~
   drivers/media/platform/apple/avd/avd-inst.h:195:41: note: in definition of macro 'push'
     195 | #define push(inst, name) push(avd, ctx, inst)
         |                                         ^~~~


vim +586 drivers/media/platform/apple/avd/avd-av1.c

   582	
   583		/* TODO: this is wrong, maybe has something to do with superres */
   584		push((frame->flags & V4L2_AV1_FRAME_FLAG_USE_SUPERRES ?
   585				(frame->superres_denom - 1) << 28 : 0) |
 > 586				frame->upscaled_width - 1, "upscaled_width");
   587		/* something superres related? test35 */
   588		push(0x200000, "flag_unk0");
   589		push(0x200000, "flag_unk1");
   590	
   591		u8 restoration_unit_size[V4L2_AV1_NUM_PLANES_MAX] = { 3, 3, 3 };
   592	
   593		if (lr->flags & V4L2_AV1_LOOP_RESTORATION_FLAG_USES_LR) {
   594			restoration_unit_size[0] = 1 + lr->lr_unit_shift;
   595			restoration_unit_size[1] =
   596				1 + lr->lr_unit_shift - lr->lr_uv_shift;
   597			restoration_unit_size[2] =
   598				1 + lr->lr_unit_shift - lr->lr_uv_shift;
   599		}
   600	
   601		push(AV1_LR_TYPE0(frame->loop_restoration.frame_restoration_type[0]) |
   602				AV1_LR_TYPE1(frame->loop_restoration.frame_restoration_type[1]) |
   603				AV1_LR_TYPE2(frame->loop_restoration.frame_restoration_type[2]) |
   604				AV1_LR_UNIT0(restoration_unit_size[0]) |
   605				AV1_LR_UNIT1(restoration_unit_size[1]) |
   606				AV1_LR_UNIT2(restoration_unit_size[2]), "lr");
   607	
   608		push(0, "cnst3");
   609		push(0, "cnst3");
   610		pusha(av1_ctx->bufs.pipe_state.addr, "pipe_state", 0);
   611		for (i = 0; i < 10; i++)
   612			pusha(av1_ctx->bufs.const_unk[i + 2].addr, "const_unk", i + 2);
   613	
   614		push(0, "mark_section");
   615	
   616		push_rvra(avd, ctx, run->addresses.rvra, ctx->rvra.offsets);
   617	
   618		push(0, "");
   619		push(0, "mark_section");
   620	
   621		bytesperline = ctx->decoded_fmt.fmt.pix_mp.plane_fmt[0].bytesperline;
   622		pusha(run->addresses.y, "y", 0);
   623		push(bytesperline, "bytesperline_y");
   624		pusha(run->addresses.uv, "uv", 0);
   625		push(bytesperline, "bytesperline_uv");
   626	
   627		push(0, "mark_section");
   628	
   629		push(AVD_HDR_HEIGHT(frame->frame_height_minus_1) |
   630				AVD_HDR_WIDTH(frame->frame_width_minus_1),
   631				"height_width_3");
   632		if (!intra_only || intrabc)
   633			set_refs(ctx, run);
   634	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki