[android-common:android16-6.12-desktop 0/1] drivers/platform/x86/thinkpad_acpi.c:10451:36: warning: declaration of 'struct platform_profile_handler' will not be visible outside of this function

Hi Kurt,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android16-6.12-desktop
head:   24c37396da197463e1ff2bc69bb789e34dacad53
commit: 82c3c913af0c82e7da403f126de414662b19d5ab [0/1] UPSTREAM: ACPI: platform_profile: Move platform_profile_handler
config: i386-randconfig-013-20260813 (https://download.01.org/0day-ci/archive/20260813/[email protected]/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260813/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/thinkpad_acpi.c:10451:36: warning: declaration of 'struct platform_profile_handler' will not be visible outside of this function [-Wvisibility]
    10451 | static int dytc_profile_get(struct platform_profile_handler *pprof,
          |                                    ^
   drivers/platform/x86/thinkpad_acpi.c:10526:36: warning: declaration of 'struct platform_profile_handler' will not be visible outside of this function [-Wvisibility]
    10526 | static int dytc_profile_set(struct platform_profile_handler *pprof,
          |                                    ^
   drivers/platform/x86/thinkpad_acpi.c:10603:27: error: too few arguments to function call, single argument 'dev' was not specified
    10603 |                 platform_profile_notify();
          |                 ~~~~~~~~~~~~~~~~~~~~~~~ ^
   include/linux/platform_profile.h:45:6: note: 'platform_profile_notify' declared here
      45 | void platform_profile_notify(struct device *dev);
         |      ^                       ~~~~~~~~~~~~~~~~~~
   drivers/platform/x86/thinkpad_acpi.c:10607:40: error: variable has incomplete type 'struct platform_profile_handler'
    10607 | static struct platform_profile_handler dytc_profile = {
          |                                        ^
   drivers/platform/x86/thinkpad_acpi.c:10607:15: note: forward declaration of 'struct platform_profile_handler'
    10607 | static struct platform_profile_handler dytc_profile = {
          |               ^
   drivers/platform/x86/thinkpad_acpi.c:10701:26: error: too few arguments to function call, single argument 'dev' was not specified
    10701 |         platform_profile_remove();
          |         ~~~~~~~~~~~~~~~~~~~~~~~ ^
   include/linux/platform_profile.h:40:5: note: 'platform_profile_remove' declared here
      40 | int platform_profile_remove(struct device *dev);
         |     ^                       ~~~~~~~~~~~~~~~~~~
   2 warnings and 3 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_PCM_IEC958
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_SOC_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_COMPRESS_ACCEL
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_JACK
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_VMASTER
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_JACK_INPUT_DEV
   Depends on [n]: SOUND [=y] && SND [=n] && SND_JACK [=y]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_INTEL_NHLT
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y] && ACPI [=y]
   WARNING: unmet direct dependencies detected for SND_PCM_ELD
   Depends on [n]: SOUND [=y] && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]


vim +10451 drivers/platform/x86/thinkpad_acpi.c

c3bfcd4c676238e Mark Pearson  2021-01-11  10446  
c3bfcd4c676238e Mark Pearson  2021-01-11  10447  /*
c3bfcd4c676238e Mark Pearson  2021-01-11  10448   * dytc_profile_get: Function to register with platform_profile
c3bfcd4c676238e Mark Pearson  2021-01-11  10449   * handler. Returns current platform profile.
c3bfcd4c676238e Mark Pearson  2021-01-11  10450   */
d2386d791cb72e0 Hans de Goede 2021-02-04 @10451  static int dytc_profile_get(struct platform_profile_handler *pprof,
c3bfcd4c676238e Mark Pearson  2021-01-11  10452  			    enum platform_profile_option *profile)
c3bfcd4c676238e Mark Pearson  2021-01-11  10453  {
c3bfcd4c676238e Mark Pearson  2021-01-11  10454  	*profile = dytc_current_profile;
c3bfcd4c676238e Mark Pearson  2021-01-11  10455  	return 0;
c3bfcd4c676238e Mark Pearson  2021-01-11  10456  }
c3bfcd4c676238e Mark Pearson  2021-01-11  10457  

:::::: The code at line 10451 was first introduced by commit
:::::: d2386d791cb72e0dcaa5f43d509a4f71c44f47d8 platform/x86: thinkpad_acpi: Fix 'warning: no previous prototype for' warnings

:::::: TO: Hans de Goede <[email protected]>
:::::: CC: Hans de Goede <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki