[soc:board-remove 132/217] drivers/i2c/busses/i2c-pxa-pci.c:41:29: warning: unused variable 'prop'

kernel test robot <[email protected]>
Newsgroups dev.linux.lists.oe-kbuild-all,org.infradead.lists.linux-arm-kernel
Message-ID <[email protected]>
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove
head:   057394422bc04420585b2790b230d8a1f350ace8
commit: 965e36538dc05c1751e466c2afa3124be407bc2d [132/217] i2c: pxa: remove platform data based probing
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260817/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260817/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

   drivers/i2c/busses/i2c-pxa-pci.c: In function 'add_i2c_device':
>> drivers/i2c/busses/i2c-pxa-pci.c:41:29: warning: unused variable 'prop' [-Wunused-variable]
      41 |                 const void *prop;
         |                             ^~~~


vim +/prop +41 drivers/i2c/busses/i2c-pxa-pci.c

7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  21  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  22  static struct platform_device *add_i2c_device(struct pci_dev *dev, int bar)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  23  {
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  24  	struct platform_device *pdev;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  25  	struct resource res[2];
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  26  	struct device_node *child;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  27  	static int devnum;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  28  	int ret;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  29  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  30  	memset(&res, 0, sizeof(res));
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  31  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  32  	res[0].flags = IORESOURCE_MEM;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  33  	res[0].start = pci_resource_start(dev, bar);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  34  	res[0].end = pci_resource_end(dev, bar);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  35  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  36  	res[1].flags = IORESOURCE_IRQ;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  37  	res[1].start = dev->irq;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  38  	res[1].end = dev->irq;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  39  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  40  	for_each_child_of_node(dev->dev.of_node, child) {
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02 @41  		const void *prop;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  42  		struct resource r;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  43  		int ret;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  44  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  45  		ret = of_address_to_resource(child, 0, &r);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  46  		if (ret < 0)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  47  			continue;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  48  		if (r.start != res[0].start)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  49  			continue;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  50  		if (r.end != res[0].end)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  51  			continue;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  52  		if (r.flags != res[0].flags)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  53  			continue;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  54  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  55  		break;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  56  	}
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  57  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  58  	if (!child) {
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  59  		dev_err(&dev->dev, "failed to match a DT node for bar %d.\n",
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  60  				bar);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  61  		ret = -EINVAL;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  62  		goto out;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  63  	}
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  64  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  65  	pdev = platform_device_alloc("ce4100-i2c", devnum);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  66  	if (!pdev) {
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  67  		of_node_put(child);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  68  		ret = -ENOMEM;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  69  		goto out;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  70  	}
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  71  	pdev->dev.parent = &dev->dev;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  72  	pdev->dev.of_node = child;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  73  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  74  	ret = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  75  	if (ret)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  76  		goto err;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  77  
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  78  	ret = platform_device_add(pdev);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  79  	if (ret)
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  80  		goto err;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  81  	devnum++;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  82  	return pdev;
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  83  err:
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  84  	platform_device_put(pdev);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  85  out:
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  86  	return ERR_PTR(ret);
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  87  }
7e94dd154e934aa Sebastian Andrzej Siewior 2011-03-02  88  

:::::: The code at line 41 was first introduced by commit
:::::: 7e94dd154e934aa2137c427c3b1c8e9a6e465fcd i2c-pxa2xx: Add PCI support for PXA I2C controller

:::::: TO: Sebastian Andrzej Siewior <[email protected]>
:::::: CC: Ben Dooks <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.