Re: [PATCH RFC] drm/verisilicon: Switch to drm_fb_dma_get_addr() for framebuffer addresses

kernel test robot <[email protected]>
Newsgroups dev.linux.lists.oe-kbuild-all
Message-ID <[email protected]>
Hi Chen-Yu,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on v7.2]
[also build test ERROR on linus/master next-20260818]
[cannot apply to drm-misc/drm-misc-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chen-Yu-Tsai/drm-verisilicon-Switch-to-drm_fb_dma_get_addr-for-framebuffer-addresses/20260807-184818
base:   v7.2
patch link:    https://lore.kernel.org/r/20260807104819.1295812-1-wenst%40chromium.org
patch subject: [PATCH RFC] drm/verisilicon: Switch to drm_fb_dma_get_addr() for framebuffer addresses
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20260820/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260820/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/verisilicon/vs_primary_plane.c: In function 'vs_primary_plane_atomic_update':
>> drivers/gpu/drm/verisilicon/vs_primary_plane.c:133:20: error: implicit declaration of function 'drm_fb_dma_get_gem_addr' [-Wimplicit-function-declaration]
     133 |         dma_addr = drm_fb_dma_get_gem_addr(fb, 0);
         |                    ^~~~~~~~~~~~~~~~~~~~~~~
--
   drivers/gpu/drm/verisilicon/vs_cursor_plane.c: In function 'vs_cursor_plane_atomic_update':
>> drivers/gpu/drm/verisilicon/vs_cursor_plane.c:180:20: error: implicit declaration of function 'drm_fb_dma_get_gem_addr' [-Wimplicit-function-declaration]
     180 |         dma_addr = drm_fb_dma_get_gem_addr(fb, 0);
         |                    ^~~~~~~~~~~~~~~~~~~~~~~


vim +/drm_fb_dma_get_gem_addr +133 drivers/gpu/drm/verisilicon/vs_primary_plane.c

    96	
    97	static void vs_primary_plane_atomic_update(struct drm_plane *plane,
    98						   struct drm_atomic_commit *atomic_state)
    99	{
   100		struct drm_plane_state *state = drm_atomic_get_new_plane_state(atomic_state,
   101									       plane);
   102		struct vs_plane_state *vs_state = to_vs_plane_state(state);
   103		struct drm_framebuffer *fb = state->fb;
   104		struct drm_crtc *crtc = state->crtc;
   105		struct vs_dc *dc;
   106		struct vs_crtc *vcrtc;
   107		unsigned int output;
   108		dma_addr_t dma_addr;
   109	
   110		if (!state->visible) {
   111			vs_primary_plane_atomic_disable(plane, atomic_state);
   112			return;
   113		}
   114	
   115		vcrtc = drm_crtc_to_vs_crtc(crtc);
   116		output = vcrtc->id;
   117		dc = vcrtc->dc;
   118	
   119		regmap_update_bits(dc->regs, VSDC_FB_CONFIG(output),
   120				   VSDC_FB_CONFIG_FMT_MASK,
   121				   VSDC_FB_CONFIG_FMT(vs_state->format.color));
   122		regmap_update_bits(dc->regs, VSDC_FB_CONFIG(output),
   123				   VSDC_FB_CONFIG_SWIZZLE_MASK,
   124				   VSDC_FB_CONFIG_SWIZZLE(vs_state->format.swizzle));
   125		regmap_assign_bits(dc->regs, VSDC_FB_CONFIG(output),
   126				   VSDC_FB_CONFIG_UV_SWIZZLE_EN,
   127				   vs_state->format.uv_swizzle);
   128	
   129		/*
   130		 * Primary plane cannot be moved, no clipping is involved,
   131		 * so the non-clipped framebuffer address can be used.
   132		 */
 > 133		dma_addr = drm_fb_dma_get_gem_addr(fb, 0);
   134	
   135		regmap_write(dc->regs, VSDC_FB_ADDRESS(output),
   136			     lower_32_bits(dma_addr));
   137		regmap_write(dc->regs, VSDC_FB_STRIDE(output),
   138			     fb->pitches[0]);
   139	
   140		regmap_write(dc->regs, VSDC_FB_TOP_LEFT(output),
   141			     VSDC_MAKE_PLANE_POS(state->crtc_x, state->crtc_y));
   142		regmap_write(dc->regs, VSDC_FB_BOTTOM_RIGHT(output),
   143			     VSDC_MAKE_PLANE_POS(state->crtc_x + state->crtc_w,
   144						 state->crtc_y + state->crtc_h));
   145		regmap_write(dc->regs, VSDC_FB_SIZE(output),
   146			     VSDC_MAKE_PLANE_SIZE(state->crtc_w, state->crtc_h));
   147	
   148		regmap_write(dc->regs, VSDC_FB_BLEND_CONFIG(output),
   149			     VSDC_FB_BLEND_CONFIG_BLEND_DISABLE);
   150	
   151		vs_primary_plane_commit(dc, output);
   152	}
   153	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.