Re: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release

Hi Eric,

kernel test robot noticed the following build errors:

[auto build test ERROR on horms-ipvs/master]
[cannot apply to net/main net-next/main linus/master v7.2 next-20260819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/l2tp-fix-tunnel-and-session-refcount-leak-on-seq_file-release/20260810-141125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
patch link:    https://lore.kernel.org/r/20260810141125.1176545-1-edumazet%40google.com
patch subject: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260820/[email protected]/config)
compiler: powerpc64-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260820/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   net/l2tp/l2tp_ppp.c: In function 'pppol2tp_proc_release':
>> net/l2tp/l2tp_ppp.c:1641:17: error: implicit declaration of function 'l2tp_session_put'; did you mean 'l2tp_session_get'? [-Wimplicit-function-declaration]
    1641 |                 l2tp_session_put(pd->session);
         |                 ^~~~~~~~~~~~~~~~
         |                 l2tp_session_get
>> net/l2tp/l2tp_ppp.c:1643:17: error: implicit declaration of function 'l2tp_tunnel_put'; did you mean 'l2tp_tunnel_get'? [-Wimplicit-function-declaration]
    1643 |                 l2tp_tunnel_put(pd->tunnel);
         |                 ^~~~~~~~~~~~~~~
         |                 l2tp_tunnel_get
--
   net/l2tp/l2tp_debugfs.c: In function 'l2tp_dfs_seq_release':
>> net/l2tp/l2tp_debugfs.c:311:17: error: implicit declaration of function 'l2tp_session_put'; did you mean 'l2tp_session_get'? [-Wimplicit-function-declaration]
     311 |                 l2tp_session_put(pd->session);
         |                 ^~~~~~~~~~~~~~~~
         |                 l2tp_session_get
>> net/l2tp/l2tp_debugfs.c:313:17: error: implicit declaration of function 'l2tp_tunnel_put'; did you mean 'l2tp_tunnel_get'? [-Wimplicit-function-declaration]
     313 |                 l2tp_tunnel_put(pd->tunnel);
         |                 ^~~~~~~~~~~~~~~
         |                 l2tp_tunnel_get


vim +1641 net/l2tp/l2tp_ppp.c

  1634	
  1635	static int pppol2tp_proc_release(struct inode *inode, struct file *file)
  1636	{
  1637		struct seq_file *seq = file->private_data;
  1638		struct pppol2tp_seq_data *pd = seq->private;
  1639	
  1640		if (pd->session)
> 1641			l2tp_session_put(pd->session);
  1642		if (pd->tunnel)
> 1643			l2tp_tunnel_put(pd->tunnel);
  1644	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki